Defect #36887
copyImageFromClipboard function failed to generate a unique file name
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Attachments | |||
Target version: | 4.2.6 | |||
Resolution: | Fixed | Affected version: |
Description
Hello,
The function copyImageFromClipboard is NOT generating unique file name but always uploading image.png.
I've confirmed the problem in chrome 99.0.4844.74, edge 100.0.1185.29, firefox 98.0.2.
This is our environment.
Environment: Redmine version 4.2.5.stable Ruby version 2.6.9-p207 (2021-11-24) [x86_64-linux-musl] Rails version 5.2.6.3 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp
Possible reason:
According from the public/javascripts/attachments.js#L283-L291 I felt that the variable 'filename' is defined but not used. Can it be the reason of this behavior?
Thank you very much for your support.
Related issues
Associated revisions
Fix that copy paste image from clipboard fails to generate a unique file name (#36887).
History
#1
Updated by Simon Hori about 1 month ago
- Copied from Patch #36817: copyImageFromClipboard function targets the first file input of the page and may conflict with other plugins added
#2
Updated by Simon Hori about 1 month ago
I am sorry Marius BALTEANU. Maybe I shouldn't have copied #36817 with the target version and the assignee. Please let me know if I should create a new issue from scratch.
#3
Updated by Marius BALTEANU about 1 month ago
- Status changed from New to Confirmed
#4
Updated by Marius BALTEANU about 1 month ago
- File 0001-Fix-copyImageFromClipboard-function-failed-to-genera.patch added
Simon, thanks for reporting this! Can you test the attached fix?
#5
Updated by Marius BALTEANU about 1 month ago
- File deleted (
0001-Fix-copyImageFromClipboard-function-failed-to-genera.patch)
#6
Updated by Marius BALTEANU about 1 month ago
#7
Updated by Simon Hori about 1 month ago
- File after-the-patch.jpg added
Awesome!! It works, thank you so much for the quick fix.
Screenshot
#8
Updated by Marius BALTEANU about 1 month ago
- Status changed from Confirmed to Resolved
- Resolution set to Fixed
#9
Updated by Marius BALTEANU about 1 month ago
Fix committed, thanks!
#10
Updated by Go MAEDA about 1 month ago
- Related to Defect #36911: Clipboard copy is broken after upgrade to 4.2.5 or 5.0.0 from 4.2.3 added
#11
Updated by Go MAEDA about 1 month ago
- Related to deleted (Defect #36911: Clipboard copy is broken after upgrade to 4.2.5 or 5.0.0 from 4.2.3)
#12
Updated by Go MAEDA about 1 month ago
- Duplicated by Defect #36911: Clipboard copy is broken after upgrade to 4.2.5 or 5.0.0 from 4.2.3 added
#13
Updated by Go MAEDA about 1 month ago
- Related to Defect #36013: Paste image mixed with other DataTransferItem added
#14
Updated by Marius BALTEANU about 1 month ago
Merged to stable branches, but I will keep this open for a few days, I would like to try add a system test.
#15
Updated by Marius BALTEANU 27 days ago
- Status changed from Resolved to Closed
I didn't find a way to add a test for this, any help is welcome.