Feature #37115

Update last_login_on when sending requests with API Key

Added by Andreas Skorczyk about 1 month ago. Updated 15 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:Candidate for next major release
Resolution:

Description

Currently, users that access Redmine through the API with a given API key won't surface, as their last_login_on field doesn't get updated. This is a bit problematic in our case, as we can't easily distinguish between an inactive user and one that solely uses the API. The attached patch would change this behavior by calling user.update_last_login_on when finding the user via the API key.
Do you think it makes sense to apply this change or are there reasons against it?

update_last_login_on_on_api_key.patch Magnifier (409 Bytes) Andreas Skorczyk, 2022-05-13 11:14


Related issues

Related to Redmine - Defect #20648: Users' "Last connection" is not updated correctly. New

History

#1 Updated by Marius BALTEANU 18 days ago

  • Target version set to Candidate for next minor release

#2 Updated by Marius BALTEANU 18 days ago

  • Target version changed from Candidate for next minor release to Candidate for next major release

Andreas Skorczyk wrote:

Do you think it makes sense to apply this change or are there reasons against it?

It makes sense to me to update the last_login_on. Any other opinions?

#3 Updated by Go MAEDA 15 days ago

I think that if last_login_on is updated by requests via API, then it should also be updated by requests via a web browser.

Current:
  • `GET /issues` via browser don't update last_login_on
  • `GET /issues.json` via API don't update last_login_on
After applying the patch:
  • `GET /issues` via browser don't update last_login_on
  • `GET /issues.json` API updates last_login_on
Should be:
  • `GET /issues` via browser updates last_login_on
  • `GET /issues.json` API updates last_login_on

#4 Updated by Go MAEDA 15 days ago

  • Related to Defect #20648: Users' "Last connection" is not updated correctly. added

Also available in: Atom PDF