Project

General

Profile

Actions

Defect #3715

closed

Login page should not show projects link and search box if authentication is required

Defect #3715: Login page should not show projects link and search box if authentication is required

Added by Lucas Panjer over 17 years ago. Updated over 15 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
UI
Target version:
Resolution:
Fixed
Affected version:

Description

If authentication is required then you can't reach any other page unless you have logged in. To avoid confusion for users and for a cleaner login page, the "Projects" link and "Search" box in the header menu should not appear. Any contribution to the header menu from plugins should also be suppressed.


Files

3715-1.diff (1.16 KB) 3715-1.diff Lucas Panjer, 2009-09-04 08:37
3715-2.patch (1.65 KB) 3715-2.patch Lucas Panjer, 2009-09-09 10:03

Related issues 1 (0 open — 1 closed)

Is duplicate of Redmine - Patch #2321: Hide search textbox if authorization requiredClosedActions

Updated by Lucas Panjer about 17 years ago Actions #1

simple approach attached in diff

Updated by Eric Davis about 17 years ago Actions #2

Nice simple implementation. It would be good to add a short integration test for this to make sure they stay hidden in the future.

Updated by Lucas Panjer about 17 years ago Actions #3

Added a test. The menu_manager test suite seemed like a roughly appropriate spot for it.
Adjusted change to remove the entire #quick-search. I don't see any point in leaving the div with no form.

The other approach to this issue is to ask each plugin to respect the login_required setting and adjust Redmine in the menu manager somewhere. This approach would preserve the ability to show menu items to unauthenticated users when login is required, which the approach in this patch does not allow.

Updated by Jean-Philippe Lang about 17 years ago Actions #4

  • Category set to UI
  • Priority changed from Normal to Low

Updated by Etienne Massip over 15 years ago Actions #5

  • Target version set to Candidate for next major release

Updated by Jean-Philippe Lang over 15 years ago Actions #6

  • Status changed from New to Closed
  • Target version changed from Candidate for next major release to 1.2.0
  • Resolution set to Fixed

Patch committed in r5007. Test slightly edited and moved to layout_test.

Updated by Denis Tomashenko over 15 years ago Actions #7

#2321 - this can be closed too

Updated by Etienne Massip over 15 years ago Actions #8

Done, thanks.

Actions

Also available in: PDF Atom