Project

General

Profile

Actions

Patch #37465

closed

Update Rails to 5.2.8.1

Added by Go MAEDA over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Files


Related issues

Related to Redmine - Defect #37719: Broken serialized columns, if saved time was with Rails 4.2ClosedGo MAEDA

Actions
Related to Redmine - Defect #37784: Crash on running v4.2.8Closed

Actions
Copied from Redmine - Patch #37452: Update Rails to 6.1.7ClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA over 1 year ago

Actions #2

Updated by Go MAEDA over 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Done in r21721.

Actions #3

Updated by Go MAEDA over 1 year ago

  • Related to Defect #37719: Broken serialized columns, if saved time was with Rails 4.2 added
Actions #4

Updated by salman mp over 1 year ago

Does it tested with Ruby < '2.6'?

I got the following exception:

/usr/lib/ruby/2.5.0/psych/nodes/node.rb:49:in `to_ruby': Cannot load database configuration: (ArgumentError)                    
wrong number of arguments (given 1, expected 0)

and this change fixes error:
Index: Gemfile
<+>UTF-8
===================================================================
diff --git a/Gemfile b/Gemfile
--- a/Gemfile
+++ b/Gemfile
@@ -25,7 +25,7 @@
 gem "rbpdf", "~> 1.20.0" 
 gem 'addressable'
 gem 'rubyzip', '~> 2.3.0'
-gem 'psych', '~> 3.1' if Gem.ruby_version < Gem::Version.new('2.6.0')
+gem 'psych', '~> 3.1.0' if Gem.ruby_version < Gem::Version.new('2.6.0')

Env:
ruby 2.5.0
redmine: 4.2.8

Actions #5

Updated by Go MAEDA over 1 year ago

salman mp wrote:

Does it tested with Ruby < '2.6'?

I got the following exception:
[...]
and this change fixes error:
[...]

Env:
ruby 2.5.0
redmine: 4.2.8

I have just tested with Ruby 2.4 and found no problems.

Since this issue is closed and the change has already been released, could you open a new issue? Also, please attach your database.yml with confidential information masked to the new issue.

Actions #6

Updated by Holger Just over 1 year ago

Actions

Also available in: Atom PDF