Project

General

Profile

Actions
Copy link

Patch #37528

closed

Don't load changesets when IssuesController#show processes API requests without "include=changesets"

Added by Go MAEDA 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Performance
Target version:
5.1.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Currently, changesets are always being loaded in IssuesController when API requests for IssuesController#show are made. However, loading Changesets is not necessary unless "include=changesets" is specified in the API request parameters.

The attached patch can improve the performance of "GET /issues/:id.(json|xml)" by loading changesets only when they are necessary.

Files

skip-loading-changesets.patch (1.23 KB) skip-loading-changesets.patch Go MAEDA, 2022-07-29 03:19
Actions
Copy link
 #1

Updated by Go MAEDA 8 months ago

  • Target version set to 5.1.0

Setting the target version to 5.1.0.

Actions
Copy link
 #2

Updated by Go MAEDA 8 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Actions
Copy link

Also available in: Atom PDF