Defect #37586

Typo in method names

Added by Mischa The Evil about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:5.1.0
Resolution:Fixed Affected version:

Description

The following methods contain a typo in their name:
  • Redmine::Scm::Adapters::AbstractAdapter#with_trailling_slash
  • Redmine::Scm::Adapters::AbstractAdapter#without_trailling_slash

This might be something that should be fixed.

37586.patch Magnifier (3 KB) Go MAEDA, 2022-08-24 16:01

Associated revisions

Revision 21785
Added by Go MAEDA about 1 month ago

Typo in method names: s/trailling/trailing/ (#37586).

Revision 21786
Added by Go MAEDA about 1 month ago

Typo in an argument name: s/trailling/trailing/ (#37586).

Revision 21791
Added by Go MAEDA about 1 month ago

Fix RuboCop offense Layout/LineLength due to r21785 (#37586).

History

#1 Updated by Go MAEDA about 1 month ago

Thank you for pointing it out. I am attaching a patch.

#2 Updated by Mischa The Evil about 1 month ago

  • Target version set to 5.1.0

LGTM.

#3 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix.

Also available in: Atom PDF