Actions
Defect #37587
closedUnnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
source:/trunk/lib/redmine/scm/adapters/filesystem_adapter.rb@21772#L24 contains the following statement:
require 'find'
As far as I can tell this requirement is obsolete and doesn't serve any purpose. None of the module's methods are used in the file and I also don't see any other references to the module.
       Updated by Go MAEDA about 3 years ago
      Updated by Go MAEDA about 3 years ago
      
    
    It looks like the `require 'find'` was already unnecessary when FilesystemAdapter was added in r1508.
Setting the target version to 5.1.0.
       Updated by Mischa The Evil about 3 years ago
      Updated by Mischa The Evil about 3 years ago
      
    
    - Subject changed from Possibly obsolete requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb to Unnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb
- Target version set to 5.1.0
Go MAEDA wrote:
It looks like the
`require 'find'`was already unnecessary whenFilesystemAdapterwas added in r1508.
You're right. It indeed looks like that's the case.
       Updated by Go MAEDA about 3 years ago
      Updated by Go MAEDA about 3 years ago
      
    
    - Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix. Thank you.
Actions