Defect #37587

Unnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb

Added by Mischa The Evil about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:5.1.0
Resolution:Fixed Affected version:

Description

source:/trunk/lib/redmine/scm/adapters/filesystem_adapter.rb@21772#L24 contains the following statement:

require 'find'

As far as I can tell this requirement is obsolete and doesn't serve any purpose. None of the module's methods are used in the file and I also don't see any other references to the module.

Associated revisions

Revision 21780
Added by Go MAEDA about 1 month ago

Fix unnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb (#37587).

Contributed by Mischa The Evil.

History

#1 Updated by Go MAEDA about 1 month ago

It looks like the `require 'find'` was already unnecessary when FilesystemAdapter was added in r1508.

Setting the target version to 5.1.0.

#2 Updated by Mischa The Evil about 1 month ago

  • Subject changed from Possibly obsolete requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb to Unnecessary requirement in /lib/redmine/scm/adapters/filesystem_adapter.rb
  • Target version set to 5.1.0

Go MAEDA wrote:

It looks like the `require 'find'` was already unnecessary when FilesystemAdapter was added in r1508.

You're right. It indeed looks like that's the case.

#3 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Also available in: Atom PDF