Defect #38073: CommonMark Markdown formatter does not support min-width, max-width, min-height, and max-height CSS properties - Redmine

Actions

Copy link

Defect #38073

closed

CommonMark Markdown formatter does not support min-width, max-width, min-height, and max-height CSS properties

Added by Go MAEDA over 2 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Text formatting

Target version:

5.0.5

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

The new CommonMark Markdown formatter should also support min-width, max-width, min-height, and max-height. These properties are already supported by Textile formatter (#26552).

diff --git a/lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb b/lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb
index b1f1cfe01..eca4859be 100644
--- a/lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb
+++ b/lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb
@@ -29,8 +29,8 @@ module Redmine

         ALLOWED_CSS_PROPERTIES = %w[
           color background-color
-          width
-          height
+          width min-width max-width
+          height min-height max-height
           padding padding-left padding-right padding-top padding-bottom
           margin margin-left margin-right margin-top margin-bottom
           border border-left border-right border-top border-bottom border-radius border-style border-collapse border-spacing

Files

38073.patch (2.01 KB) 38073.patch

Go MAEDA, 2023-01-09 09:21

Related issues

Actions

Copy link

Updated by Go MAEDA over 2 years ago

Related to Defect #37237: Common Markdown Formatter does not render all properties on HTML elements added

Actions

Copy link

Updated by Go MAEDA over 2 years ago

Related to Feature #26552: Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile added

Actions

Copy link

Updated by Go MAEDA over 2 years ago

File 38073.patch 38073.patch added
Target version set to 5.0.5

Setting the target version to 5.0.5.

Actions

Copy link

Updated by Go MAEDA over 2 years ago

Subject changed from CommonMark markdown formatter does not support min-width, max-width, min-height, and max-height CSS properties to CommonMark Markdown formatter does not support min-width, max-width, min-height, and max-height CSS properties
Status changed from New to Resolved
Assignee set to Go MAEDA
Resolution set to Fixed