Project

General

Profile

Actions

Patch #39777

closed

Remove useless method #run_in_request? from db/migrate/20221214173537_add_select_project_publicity_permission.rb

Added by Pavel Rosický 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

the method doesn't seem to be relevant ( introduced by #38048 )

diff --git a/db/migrate/20221214173537_add_select_project_publicity_permission.rb b/db/migrate/20221214173537_add_select_project_publicity_permission.rb
index aed1b07d1..7a0fee7c8 100644
--- a/db/migrate/20221214173537_add_select_project_publicity_permission.rb
+++ b/db/migrate/20221214173537_add_select_project_publicity_permission.rb
@@ -10,6 +10,4 @@ class AddSelectProjectPublicityPermission < ActiveRecord::Migration[6.1]
       r.remove_permission!(:select_project_publicity)
     end
   end
-
-  def run_in_request?; true end
 end

Related issues

Related to Redmine - Feature #38048: Introduce permission to set a project publicClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA 5 months ago

  • Target version set to 6.0.0
Actions #2

Updated by Go MAEDA 5 months ago

  • Related to Feature #38048: Introduce permission to set a project public added
Actions #3

Updated by Go MAEDA 5 months ago

  • Subject changed from Remove useless method #run_in_request? to Remove useless method #run_in_request? from db/migrate/20221214173537_add_select_project_publicity_permission.rb
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r22495. Thank you.

Actions

Also available in: Atom PDF