Project

General

Profile

Actions
Copy link

Defect #41822

closed

First icon on the Activity page is replaced with chevrons-left or chevrons-right in responsive mode

Added by Mizuki ISHIKAWA 22 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
UI - Responsive
Target version:
6.0.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
6.0.1

Description

When viewing the Activity page in responsive mode (with a narrowed screen width), the first icon displayed on the page is replaced by either a chevrons-left or chevrons-right icon.
This issue likely occurs because the logic for setting up the sidebar icons runs even when the sidebar is not present in responsive mode. https://github.com/redmine/redmine/blob/master/app/assets/javascripts/application.js#L1292-L1300

In the following screenshot, the chevrons-right icon is displayed where the issue icon should normally appear:

Files

Download all files
screenshot 2024-11-22 11.55.23.png (128 KB) screenshot 2024-11-22 11.55.23.png Mizuki ISHIKAWA, 2024-11-22 03:56
screenshot 2024-11-22 12.13.03.png (69.7 KB) screenshot 2024-11-22 12.13.03.png Mizuki ISHIKAWA, 2024-11-22 04:14
Actions
Copy link
 #1

Updated by Mizuki ISHIKAWA 22 days ago

This phenomenon seems to occur on all pages with sidebars, not just activity page.

Actions
Copy link
 #2

Updated by Mizuki ISHIKAWA 22 days ago

The problem can be resolved by clearly specifying the target of the changes, as shown in the following diff:

diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
index 068ac98d8..eb52eb701 100644
--- a/app/assets/javascripts/application.js
+++ b/app/assets/javascripts/application.js
@@ -1291,10 +1291,10 @@ function inlineAutoComplete(element) {
   };
   var applyState = function(){
     if(main.hasClass('collapsedsidebar')){
-      updateSVGIcon(main[0], 'chevrons-left')
+      updateSVGIcon(document.getElementById('sidebar-switch-button'), 'chevrons-left')
       setState('hidden');
     } else {
-      updateSVGIcon(main[0], 'chevrons-right')
+      updateSVGIcon(document.getElementById('sidebar-switch-button'), 'chevrons-right')
       setState('visible');
     }
   };

Actions
Copy link
 #3

Updated by Go MAEDA 20 days ago

  • Status changed from New to Confirmed
  • Target version set to 6.0.2
Actions
Copy link
 #4

Updated by Go MAEDA 19 days ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r23307. Thank you.

Actions
Copy link
 #5

Updated by Go MAEDA 18 days ago

  • Status changed from Resolved to Closed

Merged the fix into the 6.0-stable branch in r23313.

Actions
Copy link

Also available in: Atom PDF