Project

General

Profile

Actions
Copy link

Patch #41935

closed

Add "editable" attribute in the custom fields API response

Added by salman mp 6 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Custom fields
Target version:
5.1.8
Start date:
Due date:
% Done:

0%

Estimated time:

Description

editable field is not shown in custom fields json/xml

Files

Download all files
return_editable_field_for_UserCustomFields_in_API.patch (1.53 KB) return_editable_field_for_UserCustomFields_in_API.patch salman mp, 2024-12-04 07:30
return_editable_field_for_UserCustomFields_in_API-fixed.patch (837 Bytes) return_editable_field_for_UserCustomFields_in_API-fixed.patch salman mp, 2024-12-04 07:31
Actions
Copy link
 #2

Updated by Go MAEDA 5 months ago

  • Tracker changed from Patch to Defect
  • Subject changed from Show "editable" attribute on CustomField list API to Custom Fields API does not include "editable" attribute in the response
  • Status changed from New to Confirmed
  • Target version set to 6.0.3

Thank you for reporting this issue.
I am setting the target version to 6.0.3.

The following patch updates the tests to detect this issue.

diff --git a/test/integration/api_test/custom_fields_test.rb b/test/integration/api_test/custom_fields_test.rb
index 0df56e59a..ca772417a 100644
--- a/test/integration/api_test/custom_fields_test.rb
+++ b/test/integration/api_test/custom_fields_test.rb
@@ -29,6 +29,7 @@ class Redmine::ApiTest::CustomFieldsTest < Redmine::ApiTest::Base
       assert_select 'custom_field' do
         assert_select 'name', :text => 'Database'
         assert_select 'description', :text => 'Select one of the databases'
+        assert_select 'editable', :text => 'true'
         assert_select 'id', :text => '2'
         assert_select 'customized_type', :text => 'issue'
         assert_select 'possible_values[type=array]' do
Actions
Copy link
 #3

Updated by salman mp 5 months ago

Go MAEDA wrote in #note-2:

Thank you for reporting this issue.

The following patch updates the tests to detect this issue.

Thank you for your attention and your patch.

Actions
Copy link
 #4

Updated by salman mp 5 months ago

Go MAEDA wrote in #note-2:

The following patch updates the tests to detect this issue.

By appling my patch, the test will be failed I guess. Because my patch only returns 'editable' field if custom_field is a UserCustomField.

Actions
Copy link
 #5

Updated by Go MAEDA 4 months ago

  • Target version changed from 6.0.3 to 6.0.4
Actions
Copy link
 #6

Updated by Go MAEDA 3 months ago

  • Target version changed from 6.0.4 to 6.0.5
Actions
Copy link
 #7

Updated by Marius BĂLTEANU about 1 month ago

  • Tracker changed from Defect to Patch
  • Status changed from Confirmed to Resolved
  • Assignee set to Marius BĂLTEANU

editable attribute added to the custom fields API response.

Actions
Copy link
 #8

Updated by Marius BĂLTEANU about 1 month ago

  • Subject changed from Custom Fields API does not include "editable" attribute in the response to Add "editable" attribute in the custom fields API response
Actions
Copy link
 #9

Updated by Marius BĂLTEANU about 1 month ago

  • Status changed from Resolved to Closed
  • Target version changed from 6.0.5 to 5.1.8

Merged to stable branches.

Actions
Copy link

Also available in: Atom PDF