Actions
Defect #42509
closed
Plugin activity icons broken when multiple plugins are loaded
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Following up #41880
Stefan Rinkes wrote in #note-13:
After trying it I don't think this is probably fixed.
I still see two issues:
- Looks to me you can now only have one plugin which registers as an ActivityProvider. Icons only work for one loaded plugin.
- We have a class which inherites from Journal, which acts_as_activity_provider for issues. So [...] ends up as 'issues' and not the wanted key.
Files
Related issues
Updated by Marius BĂLTEANU about 2 months ago
- Copied from Defect #41880: Plugin activity icons broken after switching to SVG icons added
Updated by Marius BĂLTEANU about 2 months ago
- Subject changed from Plugin activity icons broken after switching to SVG icons to Plugin activity icons broken when multiple plugins are loaded
Updated by Marius BĂLTEANU about 1 month ago
Stefan Rinkes, I was able to confirm the first issue and the fix is quite small, but for the second one , can you add the relevant code to your sample plugin? I would like to be able to reproduce the issue before committing the fix.
Updated by Marius BĂLTEANU about 1 month ago
- Status changed from New to Resolved
Patch proposed by Stefan Rinkes committed.
I still want to reproduce the second issue in order to try to add some tests to have this covered.
We have a class which inherites from Journal, which acts_as_activity_provider for issues. So [...] ends up as 'issues' and not the wanted key.
Updated by Marius BĂLTEANU about 1 month ago
- Status changed from Resolved to Closed
Merged to 6.0-stable branch.
Actions