Project

General

Profile

Actions
Copy link

Defect #42584

closed

NoMethodError when creating a user with an invalid email address and domain restrictions are enabled

Added by Go MAEDA 16 days ago. Updated 12 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Administration
Target version:
5.1.8
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When "Allowed email domains" or "Disallowed email domains" are configured in Administration > Settings, attempting to create a new user with an invalid email address that does not contain an '@' causes a NoMethodError in EmailAddress.domain_in? during validation. As a result, the user sees an "Internal Server Error" page.

The attached patch fixes the issue.

Files

Download all files
fix-email-address-domain_in.patch (1.13 KB) fix-email-address-domain_in.patch Go MAEDA, 2025-04-15 11:17
fix-email-address-domain_in-v2.patch (1.51 KB) fix-email-address-domain_in-v2.patch Go MAEDA, 2025-04-16 07:46
Actions
Copy link
 #1

Updated by Go MAEDA 15 days ago

I have updated the patch.

The updated patch also skips domain validation to avoid displaying an error message with an empty domain name, such as "Email contains a domain not allowed ()".

Actions
Copy link
 #2

Updated by Go MAEDA 14 days ago

  • Target version changed from Candidate for next minor release to 5.1.8

Setting the target version to 5.1.8.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU 12 days ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed
Actions
Copy link
 #4

Updated by Go MAEDA 12 days ago

  • Status changed from Resolved to Closed

Committed the fix in r23666 and merged it into stable branches in r23681 and r23682.

Actions
Copy link

Also available in: Atom PDF