Redmine

It seems that commit r23956 caused the following test to fail:
https://github.com/redmine/redmine/actions/runs/17525877800/job/49776196037#step:5:49

Failure:
UserPreferenceTest#test_auto_watch_on_should_default_to_options [test/unit/user_preference_test.rb:72]:
--- expected
+++ actual
@@ -1 +1 @@
-["issue_created", "issue_contributed_to"]
+"" 

bin/rails test test/unit/user_preference_test.rb:69

Note that several other tests are also failing, but I believe those are due to a different cause.

Here is the patch for #note-4.

diff --git a/test/unit/user_preference_test.rb b/test/unit/user_preference_test.rb
index fd51b1d9f..582520402 100644
--- a/test/unit/user_preference_test.rb
+++ b/test/unit/user_preference_test.rb
@@ -67,10 +67,8 @@ class UserPreferenceTest < ActiveSupport::TestCase
   end

   def test_auto_watch_on_should_default_to_options
-    with_settings :default_users_auto_watch_on => nil do
-      preference = UserPreference.new
-      assert_equal %w[issue_created issue_contributed_to], preference.auto_watch_on
-    end
+    preference = UserPreference.new
+    assert_equal %w[issue_created issue_contributed_to], preference.auto_watch_on
   end

   def test_create

I've fixed for now the test by removing the invalid with_settings :default_users_auto_watch_on => nil, I'm going to review the cases later.

Katsuya HIDAKA wrote in #note-5:

Here is the patch for #note-4.
[...]

Thanks, I've already applied the same changes, please see my previous note.