Project

General

Profile

Actions

Patch #42972

open

Refactor and unify the structure of journals, replies and comments

Added by Marius BĂLTEANU 21 days ago. Updated 14 days ago.

Status:
Resolved
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

There are 3 places where the user can add notes with different terminologies:
  1. Notes for issues
  2. Replies for forums/boards
  3. Comments for news
In terms of HTML / CSS, even if the look and feel it is almost the same, each has it own definitions in CSS. Regarding Issues, we display 3 kind of information with a similar structure:
  • issue history (all / notes / property changes)
  • timelogs
  • revisions

Working on #40744, I made a patch that brings the following changes:

1. Refactor and unify the structure using journal as common terminology between all five entities (issue, timelog, revision, reply, comment). The change introduces/uses the following classes:

journals: main container that contains all the journals
---> journal: journal entry
-------> journal-header with journal-info and journal-meta and/or journal-actions. journal-meta can be used when there are other elements to display beside journal-actions.
-------> journal-content with journal-display instead of just display

2. Migrate from actions from contextual that is using float to flex rules in order to display the actions / indices on the right

3. Simplify/cleanup the CSS rules.

The patch also brings an updated UI for notes (#40744).


Files


Related issues

Related to Redmine - Feature #40744: Refresh history tabs look and feelClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Marius BĂLTEANU 21 days ago

I would like to take some feedback before committing this because of the structure changes that will affect themes / plugins developers.

Actions #2

Updated by Go MAEDA 15 days ago

Nice improvement!

Actions #3

Updated by Marius BĂLTEANU 14 days ago

Actions #4

Updated by Marius BĂLTEANU 14 days ago

  • Status changed from New to Resolved
  • Assignee set to Marius BĂLTEANU

Change committed in r23887 together with #40744. I'm keeping this open for a while for any issue / feedback.

Actions

Also available in: Atom PDF