Project

General

Profile

Actions

Patch #43435

open

Check missing copyright sections using Rubocop

Added by Marius BĂLTEANU 24 days ago. Updated 24 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We can find ruby files without copyright section using the cop Style/Copyright.

Actions #1

Updated by Marius BĂLTEANU 24 days ago

Go MAEDA, I was able to find the files, but I cannot make it the autocorrect to work as expected, it inserts the copy before the frozen string. Do you see any problem if we add this check, but without an working autocorrect?

Actions #2

Updated by Go MAEDA 24 days ago

Marius BĂLTEANU wrote in #note-1:

Go MAEDA, I was able to find the files, but I cannot make it the autocorrect to work as expected, it inserts the copy before the frozen string. Do you see any problem if we add this check, but without an working autocorrect?

I don't think the fact that the auto-correction doesn't work as intended is a major issue.

I rarely use auto-correction myself, and even if the Style/Copyright auto-correction accidentally inserts the copyright header before the frozen_string_literal comment, I always review the changes before committing them.

Therefore, even if the auto-correction does not behave as expected, I have no objection to adding the Style/Copyright rule to the RuboCop configuration.

Actions

Also available in: Atom PDF