Project

General

Profile

Actions

Patch #43677

open

Remove unused properties from `a.sort` selector

Added by Go MAEDA about 4 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This patch removes properties that no longer have any effect from the a.sort selector.

diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 9ee9e4ffc..051ee3cea 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -545,7 +545,7 @@ table.list:not(.odd-even) tbody tr:nth-child(even):hover, .even:hover { backgrou

 tr.builtin td.name {font-style:italic;}

-a.sort { padding-right: 16px; background-position: 100% 50%; background-repeat: no-repeat; }
+a.sort { padding-right: 16px; }

 table.boards td.last-message {text-align:left;font-size:93%;}

Redmine previously used raster icons in the UI. At that time, column headers of some tables displayed raster icons to indicate ascending or descending sort order. The background-* properties were used to position these icons added by the following CSS.

.icon-sorted-asc { background-image: url(../images/arrow_down.png); }
.icon-sorted-desc { background-image: url(../images/arrow_up.png); }

However, the ascending/descending raster icons were replaced with SVG icons in Redmine 6.0. More recently, support for raster icons was completely removed from application.css in r24029.

As a result, the background-* properties in the a.sort selector no longer have any effect and can be safely removed.

No data to display

Actions

Also available in: Atom PDF