Feature #44037
open
To be independent of the version of the Tabler library
Description
Hello, some plugins who needs new icon from a newer version of tabler-icon we can change icons.rake like this :
unless Rails.env.production?
require 'net/http'
require 'json'
def fetch_latest_tabler_version
url = URI("https://api.github.com/repos/tabler/tabler-icons/releases/latest")
response = Net::HTTP.get(url)
json = JSON.parse(response)
json["tag_name"] # ex: "v3.43.0"
end
ICON_RELEASE_VERSION = fetch_latest_tabler_version
ICON_DEFAULT_STYLE = "outline"
SOURCE = URI.parse("https://raw.githubusercontent.com/tabler/tabler-icons/#{ICON_RELEASE_VERSION}/icons")
...
Like this we are always on the last release.
Best regards
Related issues
Updated by Go MAEDA about 9 hours ago
- Related to Patch #44038: Update Tabler Icons to v3.43.0 added
Updated by Go MAEDA about 7 hours ago
Thank you for the suggestion.
I understand that plugin authors may want to use icons that were added in newer versions of Tabler Icons.
However, I am concerned about using latest for ICON_RELEASE_VERSION. If Redmine uses latest, it becomes harder to know which Tabler Icons version was used to generate app/assets/images/icons.svg. It could also make release management and bug reproduction more difficult, because running the same rake task at different times may produce different results.
Icons are part of Redmine's UI, so I think Redmine should explicitly control which icon version is used and which appearance is shipped in each release.
Possible alternatives might be to update the fixed Tabler Icons version in Redmine more regularly, or to allow developers and plugin authors to explicitly override the version when needed.