Defect #44243: Fix RuboCop Style/ArrayIntersect offenses - Redmine

Actions

Copy link

Defect #44243

closed

Fix RuboCop Style/ArrayIntersect offenses

Added by Go MAEDA about 2 months ago. Updated about 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Code cleanup/refactoring

Target version:

7.0.1

Resolution:

Fixed

Affected version:

7.0.0

Description

This patch fixes Style/ArrayIntersect offenses reported by RuboCop 1.88.2. Both trunk and 7.0-stable are affected.

app/models/issue_query.rb:409:12: C: [Correctable] Style/ArrayIntersect: Use ["#{Issue.table_name}.id ASC", "#{Issue.table_name}.id DESC"].intersect?(order_option) instead of ["#{Issue.table_name}.id ASC", "#{Issue.table_name}.id DESC"].any?{|i| order_option.include?(i)}.
    unless ["#{Issue.table_name}.id ASC", "#{Issue.table_name}.id DESC"].any?{|i| order_option.include?(i)}
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/models/issue_query.rb:460:12: C: [Correctable] Style/ArrayIntersect: Use ["#{Issue.table_name}.id ASC", "#{Issue.table_name}.id DESC"].intersect?(order_option) instead of ["#{Issue.table_name}.id ASC", "#{Issue.table_name}.id DESC"].any?{|i| order_option.include?(i)}.
    unless ["#{Issue.table_name}.id ASC", "#{Issue.table_name}.id DESC"].any?{|i| order_option.include?(i)}
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Files

fix-ArrayIntersect.diff (1.19 KB) fix-ArrayIntersect.diff

Go MAEDA, 2026-07-09 05:16