Feature #44509
closed
Dim avatars of inactive users to make them distinguishable at a glance
Description
This patch dims the avatars of inactive (locked or registered) users with opacity: .6, so that they can be recognized at a glance.
Currently, an inactive user is indicated only by the name: administrators see it as a gray link (r10673), and other users see it as plain text without a link (r3024, #4182). Avatars, however, look the same as those of active users, even though they are often more prominent than names, for example in the issue author and assignee fields, the issue history, and the watcher list. This makes it easy to overlook that a user has been locked. Since Redmine 6.1 (#29824), initials avatars are shown even when Gravatar is disabled, so this problem now affects many more installations.
With this patch, avatars of inactive users are dimmed for all viewers. This works for both Gravatar and initials avatars and complements the existing indications on names. Screenshots comparing the appearance before and after the change are attached.
Before and After (gravatar-enabled):
Before and After (gravatar-disabled):
Files
Updated by Go MAEDA 16 days ago
- File 0001-Dim-avatars-of-inactive-users-so-that-locked-users-c.patch 0001-Dim-avatars-of-inactive-users-so-that-locked-users-c.patch added
I have updated the patch. Instead of adding a new inactive class, it adds the status of the user (active, registered, locked, or anon) as a class to every user avatar. These are the labels in User::LABEL_BY_STATUS, which are already used for user links.
This change makes the class names consistent with user links and allows themes and plugins to style avatars by status. Avatars with the locked or registered class are dimmed, so the appearance is the same as with the previous patch. In addition, the condition in the helper becomes simpler.
Some existing tests that check the class attribute have been updated accordingly.