Project

General

Profile

Actions

Defect #44570

closed

Empty journal-note div is rendered for time entries without comments

Defect #44570: Empty journal-note div is rendered for time entries without comments

Added by Florian Walchshofer about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Resolution:
Fixed
Affected version:

Description

Attached patch skips rendering the journal-note div when a time entry has no comments.

This removes unnecessary empty markup and keeps the generated HTML cleaner.


Files

Updated by Go MAEDA about 2 months ago Actions #1

  • Category changed from UI to Issues
  • Target version set to 7.1.0

Setting the target version to 7.1.0.

This patch improves consistency between the tabs: the History tab already skips the .journal-note div when a journal has no notes, and with this patch the Spent time tab does the same.

Updated by Go MAEDA about 1 month ago Actions #2

  • Tracker changed from Patch to Defect
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r25200. Thank you.

Actions

Also available in: PDF Atom