Project

General

Profile

Actions

Patch #44650

open

Skip issue update notifications for deleted issues

Added by Katsuya HIDAKA about 12 hours ago. Updated about 8 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:

Description

An issue update notification can raise NoMethodError if the issue is deleted after its journal is loaded. This patch skips email generation in that case to prevent the error.

For example, this can happen when bulk deleting a parent issue and its child, with the child deleted first:

  1. Deleting the child creates a journal for the parent and queues an update notification.
  2. The notification job loads the journal. The bulk deletion then deletes the parent.
  3. Email generation cannot find the parent through the journal and raises NoMethodError.

Details:

  • Return from Mailer#issue_edit when journal.journalized is nil.
  • Reproduced this order of loading and deletion and confirmed that the patched code raises no error and sends no email.
  • Confirmed that all tests pass.

Files

Actions #1

Updated by Go MAEDA about 8 hours ago

  • Target version set to 6.1.6

Setting the target version to 6.1.6.

Actions

Also available in: Atom PDF