Project

General

Profile

Actions
Copy link

Patch #44704

closed

Update Nokogiri to 1.19.7 or later

Added by Go MAEDA 1 day ago. Updated 1 day ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Gems support
Target version:
6.1.7

Description

https://nokogiri.org/CHANGELOG.html

Related issues

Related to Redmine - Defect #44703: Tests using a Regexp with :match in assert_select fail with Nokogiri 1.19.5 and laterClosedGo MAEDAActions
Blocks Redmine - Defect #44705: SanitizationFilterTest#test_should_sanitize_html_strings fails with Nokogiri 1.19.5 and laterClosedGo MAEDAActions
Actions
Copy link
 #1

Updated by Go MAEDA 1 day ago

  • Related to Defect #44703: Tests using a Regexp with :match in assert_select fail with Nokogiri 1.19.5 and later added
Actions
Copy link
 #2

Updated by Go MAEDA 1 day ago

  • Blocked by Defect #44705: SanitizationFilterTest#test_should_sanitize_html_strings fails with Nokogiri 1.19.5 and later added
Actions
Copy link
 #3

Updated by Go MAEDA 1 day ago

  • Subject changed from Update Nokogiri to 1.19.5 or later to Update Nokogiri to 1.19.7 or later

#44705 updates the expected value in SanitizationFilterTest to match a change in the HTML5 serializer introduced in Nokogiri 1.19.5. After that change is applied, the test will fail with Nokogiri 1.19.4 and earlier, so Nokogiri must be updated to 1.19.5 or later.

I will update Nokogiri to 1.19.7, which is the latest version at the time of writing.

Actions
Copy link
 #4

Updated by Go MAEDA 1 day ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA

Committed the patch in r25416.

Actions
Copy link
 #5

Updated by Go MAEDA 1 day ago

  • Blocked by deleted (Defect #44705: SanitizationFilterTest#test_should_sanitize_html_strings fails with Nokogiri 1.19.5 and later)
Actions
Copy link
 #6

Updated by Go MAEDA 1 day ago

  • Blocks Defect #44705: SanitizationFilterTest#test_should_sanitize_html_strings fails with Nokogiri 1.19.5 and later added
Actions
Copy link
 #7

Updated by Go MAEDA 1 day ago

  • Status changed from Resolved to Closed

Merged the change into the stable branches in r25418 and r25419.

Actions
Copy link

Also available in: Atom PDF