Project

General

Profile

Actions

Feature #44739

open

Upgrade jQuery UI to 1.14.2

Added by Go MAEDA about 14 hours ago. Updated about 12 hours ago.

Status:
New
Priority:
Normal
Assignee:
Category:
Third-party libraries
Target version:
Resolution:

Description

This patch upgrades jQuery UI from 1.13.3 to 1.14.2, the latest release. The jQuery UI team no longer supports the 1.13.x series.

jQuery UI 1.14 disables the 1.11 backward compatibility API by default. As a result, the deprecated dialogClass option no longer has any effect. This patch replaces it in showModal with the classes option. The patch keeps the default ui-corner-all class, so modal dialogs look the same as before.

Two other changes in 1.14 need no changes in Redmine:

  • The sortable workaround added in #44372 for jquery/jquery-ui#2062 is still needed and still works. That issue is still open, and _setHandleClassName is unchanged in 1.14.2.
  • The default .ui-widget-overlay opacity in the bundled CSS has changed from .003 to .3. Redmine overrides this value in application.css, so the overlay looks the same.

I checked the following:

Automated checks:

  • All system tests pass.
  • RuboCop and Stylelint report no offenses.

Modal dialogs (CSV export, Add watcher):

  • Dialogs have the modal and ui-corner-all classes and the aria-modal="true" attribute.
  • Dialogs behave as before: focus, dragging and closing work as expected.

Other features:

  • Tooltips on query links in the sidebar
  • Autocomplete for related issues, including keyboard selection
  • The file upload progress bar
  • Sorting trackers (Administration) and My page blocks, including saving the new order
  • Resizing Gantt columns
  • The highlight effect

Files

Actions #1

Updated by Go MAEDA about 12 hours ago

  • Assignee set to Go MAEDA
  • Target version changed from Candidate for next major release to 7.1.0

I have started working on removing Redmine's dependency on jQuery UI. Since we need to discuss how jQuery UI should be handled going forward, I will put this issue on hold for now.

If the removal is not completed before the release of Redmine 7.1.0, I think the attached patch should be committed as is.

Actions

Also available in: Atom PDF