Defect #4718

MenuManager dies if you delete all items and then re-add

Added by Robert Chady over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:2010-02-02
Priority:NormalDue date:
Assignee:Eric Davis% Done:

100%

Category:Plugin API
Target version:0.9.3
Resolution:Fixed Affected version:0.9.2

Description

If you delete all items for :top_menu and try to push new ones back, it errors out. An easy workaround is to delete one and push its replacement. The error output is attached.

redmine_menumanager_error.txt Magnifier (2.79 KB) Robert Chady, 2010-02-02 20:52

Associated revisions

Revision 3447
Added by Eric Davis over 7 years ago

Fix an IndexError if all the :last menu items are deleted from a menu. #4718

History

#1 Updated by Eric Davis over 7 years ago

  • Status changed from New to 7

Robert brought this to my attention on IRC. A workaround is to make sure a menu always has at least one item in it.

#2 Updated by Eric Davis over 7 years ago

  • Status changed from 7 to Resolved
  • Target version set to 0.9.3
  • % Done changed from 0 to 100
  • Affected version (unused) set to 0.9.2
  • Resolution set to Fixed
  • Affected version set to 0.9.2

It turned out that the counters used to keep track of the :last menu items weren't decremented when an item was removed. This caused the menu to try to position the new menu item at a negative position.

Thanks for the bug report, I'm happy this was found. Fixed in r3447.

#3 Updated by Jean-Philippe Lang over 7 years ago

  • Status changed from Resolved to Closed

Merged in 0.9-stable in r3461.

Also available in: Atom PDF