Defect #5251
Git: Repository path encoding of non UTF-8 characters
| Status: | Closed | Start date: | 2010-04-07 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: |  Toshi MARUYAMA | % Done: | 100% | |
| Category: | SCM | |||
| Target version: | 1.2.0 | |||
| Resolution: | Fixed | Affected version: | 0.9.3 |
Description
If filename include Scandinavian character, Redmine convert them another character. In this case, filename TEKIJÄT replaces string "TEKIJ\303\204T".
Related issues
Associated revisions
scm: git: add core.quotepath = true in test repository config (#5251).
scm: git: add core.quotepath = false to run git command (#5251).
scm: git: change core.quotepath = true temporarily to run git command (#5251).
scm: git: use core.quotepath = true to run git command for database safety (#5251).
scm: git: remove "core.quotepath = true" to run git command (#5251).
If path encoding is UTF-8, git adapter may run on Linux.
scm: git: update test repository for path encoding (#5251).
Mercurial and Git treats file names as byte string.
This git test repository contains Latin-1 encoding path.
Be careful on non Latin-1(CP1252) Windows.
Please see r4996 comment.
I removed a revision including "copied file" from r5026 test repository.
Mercurial supports "copy", but Git does not support.
scm: git: add instance variable for path encoding in adapter (#5251).
scm: git: convert path encoding in "git log" (#5251).
scm: git: support path encoding in adapter revisions() (#5251).
scm: git: support path encoding in adapter diff (#5251).
scm: git: support path encoding in adapter entries() (#5251).
scm: git: support path encoding in adapter blame (#5251).
scm: git: support path encoding in adapter cat (#5251).
scm: git: add tests for path encoding cat, diff and blame in unit adapter test (#5251).
scm: git: add core.quotepath = false to run git command (#5251).
scm: git: add tests for path encoding entries() in unit adapter test (#5251).
scm: git: prepare path encoding test in unit model test (#5251).
scm: git: prepare path encoding test in unit model test (#5251).
scm: git: add latest changesets path encoding test in unit model test (#5251).
scm: git: add latin-1 encoding directory to test repository (#5251).
scm: git: fix latin-1 directory entries() in adapter (#5251).
scm: git: add latin-1 encoding directory test in unit adapter test (#5251).
scm: git: add latin-1 encoding directory test in unit model test (#5251).
scm: git: add path encoding select box at setting (#5251).
scm: git: fix unit adapter test fails in Ruby 1.9 Linux latin-1 locale (#5251).
scm: git: fix unit adapter test fails in Ruby 1.9 Linux latin-1 locale (#5251).
scm: git: change core.quotepath to false in test repository config (#5251).
The -c option was introduced in git version (1.7.2)
http://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.7.2.txt
scm: git: switch "-c core.quotepath=false" in git version above 1.7.2 or not (#5251).
The -c option was introduced in git version (1.7.2)
http://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.7.2.txt
scm: git: fix PortgreSQL functional test fails (#5251).
scm: git: unit adapter latin-1 path encoding test passes on Japanese Windows (#5251).
Ruby uses ANSI api to fork a process on Windows.
Japanese Shift_JIS and Traditional Chinese Big5 have 0x5c(backslash) problem
and these are incompatible with ASCII.
scm: git: unit model latin-1 path encoding test passes on Japanese Windows (#5251).
Ruby uses ANSI api to fork a process on Windows.
Japanese Shift_JIS and Traditional Chinese Big5 have 0x5c(backslash) problem
and these are incompatible with ASCII.
scm: git: fix loss non ASCII paths if path_encoding is '' (#5251).
scm: git: override "path_encoding" method in adapter (#5251).
scm: git: add unit adapter test of default path_encoding is UTF-8 (#5251).
scm: git: skip non UTF-8 path encoding test of functional test in JRuby (#5251).
Git, Mercurial and CVS path encodings are binary.
Subversion supports URL encoding for path.
Redmine Mercurial adapter and extension use URL encoding.
Git accepts only binary path in command line parameter.
So, there is no way to use binary command line parameter in JRuby.
scm: git: skip non UTF-8 path encoding test of unit adapter test in JRuby (#5251).
Git, Mercurial and CVS path encodings are binary.
Subversion supports URL encoding for path.
Redmine Mercurial adapter and extension use URL encoding.
Git accepts only binary path in command line parameter.
So, there is no way to use binary command line parameter in JRuby.
scm: git: skip non UTF-8 path encoding test of unit model test in JRuby (#5251).
Git, Mercurial and CVS path encodings are binary.
Subversion supports URL encoding for path.
Redmine Mercurial adapter and extension use URL encoding.
Git accepts only binary path in command line parameter.
So, there is no way to use binary command line parameter in JRuby.
History
#1
Updated by Toshi MARUYAMA over 9 years ago
Try "git config --global core.quotepath false".
#2
Updated by Toshi MARUYAMA over 9 years ago
If your filename encoding is not UTF-8, try #2664 patches.
#3
Updated by Felix Schäfer over 9 years ago
I'd have told you to try to set RedmineSettings to whatever locale "scandinavian" is, but it seems it pertains only to file contents, not file names.
#4
Updated by Toshi MARUYAMA over 9 years ago
- File git-filename-encoding-setting.png added
http://www.redmine.org/issues/2664#note-4
Mercurial (and also Git) treats file names as byte string.
Here we need to convert them to UTF-8,
but, there's no reliable info about file name encoding.
#5
Updated by Toshi MARUYAMA almost 9 years ago
- Subject changed from Redmine can't show Scandinavian character in filenames in git repository to Git: Redmine can't show Scandinavian character in filenames in git repository
#6
Updated by Toshi MARUYAMA almost 9 years ago
#7
Updated by Toshi MARUYAMA almost 9 years ago
- Priority changed from Normal to Low
Ruby 1.9 compatibility is very serious.
#8
Updated by Toshi MARUYAMA almost 9 years ago
- Subject changed from Git: Redmine can't show Scandinavian character in filenames in git repository to Git: Repository path encoding of non UTF-8 characters
- Assignee set to Toshi MARUYAMA
#9
Updated by Toshi MARUYAMA almost 9 years ago
- Status changed from New to Closed
- Assignee deleted (
Toshi MARUYAMA) - Resolution set to Wont fix
It is impossible to fix this issue in current git adapter scheme.
Please see r5027 comment.
#10
Updated by Toshi MARUYAMA almost 9 years ago
- Status changed from Closed to Reopened
- Assignee set to Toshi MARUYAMA
- Resolution deleted (
Wont fix)
#11
Updated by Toshi MARUYAMA almost 9 years ago
Toshi MARUYAMA wrote:
It is impossible to fix this issue in current git adapter scheme.
Please see r5027 comment.
$ git cat-file commit f85f88f507577dd2fa197db9e330875b2ea0757f tree 887f4cf35a6ed3acd3bf72843b65884d8f637029 parent 57ca437c0acbbcb749821fdf3726a1367056d364 author jsmith <jsmith@foo.bar> 1285909440 -0500 committer jsmith <jsmith@foo.bar> 1285909440 -0500 copy latin-1 file. --HG-- rename : latin-1-dir/test-?.txt => latin-1-dir/test-?-1.txt
$ git cat-file commit 67e7792ce20ccae2e4bb73eed09bb397819c8834 | iconv -f ISO-8859-1 -t UTF-8 tree 1ec7b464f0331a7d597ee2461ec58b3a0af11114 parent 7234cb2750b63f47bff735edc50a1c0a433c2518 author test latin-1 ÀÈÁÉÂÊÃËÄÅÆÇ <test@example.com> 1285909200 -0500 committer test latin-1 ÀÈÁÉÂÊÃËÄÅÆÇ <test@example.com> 1285909200 -0500 encoding ISO-8859-1 latin-1 ÀÈÁÉÂÊÃËÄÅÆÇ
Git log is binary, and f85f88f507577d log is broken.
#12
Updated by Toshi MARUYAMA almost 9 years ago
- % Done changed from 0 to 90
#13
Updated by Jean-Philippe Lang almost 9 years ago
r5049 broke all git tests with the git version currently used on the CI server (http://www.redmine.org/builds/index.html). The -c option was introduced in a recent git version (1.7.2). Is there any workaround for older versions?
#14
Updated by Toshi MARUYAMA almost 9 years ago
- Status changed from Reopened to 7
- Target version set to 1.2.0
#15
Updated by Toshi MARUYAMA almost 9 years ago
Jean-Philippe Lang wrote:
r5049 broke all git tests with the git version currently used on the CI server (http://www.redmine.org/builds/index.html). The -c option was introduced in a recent git version (1.7.2). Is there any workaround for older versions?
#16
Updated by Toshi MARUYAMA almost 9 years ago
- File Shift_JIS.png added
- Status changed from 7 to Closed
- % Done changed from 90 to 100
- Resolution set to Fixed
I finished implementing in r5072.
Limitation¶
- Subversion supports URL encoding path and Redmine uses it.
Mercurial adapter helper extension wraps path with URL encoding.
Git adapter uses byte string to call "git" command.
Because Ruby uses ANSI api to fork a process on Windows,
it may have trouble in different locale on Windows. - Git adapter uses "-c core.quotepath=false" if git version is above 1.7.2
at source:trunk/lib/redmine/scm/adapters/git_adapter.rb@5069#L342 .
If your git is older than 1.7.2, you need to set "core.quotepath=false" in "config". - Japanese Shift_JIS and Traditional Chinese Big5 have 0x5c(backslash) problem.
#17
Updated by Toshi MARUYAMA almost 9 years ago
Toshi MARUYAMA wrote:
- Subversion supports URL encoding path and Redmine uses it.
Mercurial adapter helper extension wraps path with URL encoding.
Git adapter uses byte string to call "git" command.
Because Ruby uses ANSI api to fork a process on Windows,
it may have trouble in different locale on Windows.
Related Ruby issue:
Bug 1771
system()/popen()/popen3() & windows & unicode is not working
http://redmine.ruby-lang.org/issues/show/1771