Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows server
|Assignee:||Toshi MARUYAMA||% Done:|
Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows server. The corruption is 100% repeatable.
The patch is a one character change at source:trunk/lib/redmine/scm/adapters/abstract_adapter.rb#L191.
< IO.popen(cmd, "r+") do |io| ---- > IO.popen(cmd, "r+b") do |io|
On Windows, without this change the pipe is opened in text mode and any 0x1A bytes are treated as EOF and subsequent bytes already in the pipe are discarded.
Note: "r+b" is equivalent to "r+" on non-Windows platforms, so this patch should be harmless for all platforms.
#4 Updated by Gareth Sylvester-Bradley over 10 years ago
Gareth, Could you try this patch?
Your patch works great on my system, thanks.
You probably spotted that my original patch was flawed, since some of the other calls to shellout() need to be opened using "r+" instead of "r+b"; since submitting my original one, I modified it locally to pass the mode as an argument with a default of "r+".
Your solution is neater!
And where can I download Windows CVS 1.12 binary?
My CVS servers are running CVS 1.11 (stable), although I'd like CVS 1.12 for the enhanced directory listing. At the moment, I'm relying on patch #4113.
My Redmine server seems to have very old CVSNT 2.5.03 client.Links:
- http://ftp.gnu.org/non-gnu/cvs/binary/stable/x86-woe/ (Windows CVS 1.11)
- http://ftp.gnu.org/non-gnu/cvs/binary/feature/x86-woe/ (Windows CVS 1.12)