Project

General

Profile

Actions
Copy link

Defect #6090

closed

Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows server

Added by Gareth Sylvester-Bradley over 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toshi MARUYAMA
Category:
SCM
Target version:
1.1.2
Start date:
2010-08-09
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
1.1.1

Description

Most binary files become corrupted when downloading from CVS repository browser when Redmine is running on a Windows server. The corruption is 100% repeatable.

The patch is a one character change at source:trunk/lib/redmine/scm/adapters/abstract_adapter.rb#L191.

<             IO.popen(cmd, "r+") do |io|
----
>             IO.popen(cmd, "r+b") do |io|

On Windows, without this change the pipe is opened in text mode and any 0x1A bytes are treated as EOF and subsequent bytes already in the pipe are discarded.

Note: "r+b" is equivalent to "r+" on non-Windows platforms, so this patch should be harmless for all platforms.

Files

cvs-cat-bin.diff (517 Bytes) cvs-cat-bin.diff Toshi MARUYAMA, 2011-02-10 00:49

Related issues

Related to Redmine - Defect #2664: Mercurial: Repository path encoding of non UTF-8 charactersClosedToshi MARUYAMA2009-02-04

Actions
Actions
Copy link

Also available in: Atom PDF