Patch #7664

Allowing plugins to add an option for the default gravatar

Added by Yuki Sonoda about 9 years ago. Updated almost 9 years ago.

Status:NewStart date:2011-02-20
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Plugin API
Target version:-

Description

Now redmine administrator can set the default gravatar for users which has no gravatar. I would like to use my own default gravatar.

The attached patch allows plugins to add an option for the default gravatar. https://github.com/yugui/redmine_fox_gravatar is an example plugin that uses this feature.

adding-gravatar-options.patch Magnifier (3.51 KB) Yuki Sonoda, 2011-02-20 09:07

adding-gravatar-options2.patch Magnifier (3.32 KB) Yuki Sonoda, 2011-02-20 09:23

add-gravatars-like-themes.patch Magnifier (7.68 KB) Yuki Sonoda, 2011-02-21 02:13

History

#2 Updated by Yuki Sonoda about 9 years ago

Oops, I attached a wrong patch. Please use adding-gravater-options2.patch.

#3 Updated by Yuki Sonoda about 9 years ago

Felix Schäfer suggested that developing a plugin just for a default gravatar is overdoing. https://www.chiliproject.org/issues/212

So I rewrote the patch. The new patch scans public/gravatars/ and adds the found files to options for the default gravatar, just like themes. I am glad if you merge the patch.

#4 Updated by Toshi MARUYAMA about 9 years ago

I have some questions.

  • Is copyright correct?
    Please see note-204 of #4455.
  • Is .gitignore correct?

#6 Updated by Yuki Sonoda about 9 years ago

I wrote the gravatar management based on the theme management. So it is an derivative of Redmine itself, particulary lib/redmine/themes.rb and test/unit/lib/redmine/thmes_test.rb.
I believe the copyright is correct. It should inherit JPL's copyright entry. Do you mean I should have added my own copyright entry?

And I believe .gitignore is also correct. This is because an additional gravatar is not a part of redmine. It is correct unless Redmine itself will have its own additional gravatar.

#7 Updated by Jean-Baptiste Barth about 9 years ago

The license looks good to me, since 1) Redmine project is globally copyrighted by Jean-Philippe, and 2) many files would need a license update anyway. But we could include copyright from other people too, depends on Jean-Philippe thoughts on this point.

The .gitignore looks correct too, but I'll put it in the main .gitignore file as not everybody is familiar with Git here, it will be easier to maintain.

Any other blocker to include this ?

#8 Updated by Yuki Sonoda almost 9 years ago

any progress?

#9 Updated by Jean-Philippe Lang almost 9 years ago

This feature doesn't seem to be needed by a lot of people, so if you don't mind, I'd prefer to commit the plugin based solution. Is it OK for you?

Also available in: Atom PDF