Project

General

Profile

Actions

Defect #8139

closed

p.push is not an object in dragdrop.js @379

Added by Daniel Tsviatkov about 14 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Gantt
Target version:
-
Start date:
2011-04-13
Due date:
% Done:

100%

Estimated time:
0.10 h
Resolution:
Affected version:

Description

the patch should look like this
Line Bourdages 376 of dragdrop.js

---p = Position.page(this.options.scroll);
+++p = Position.page(this.options.scroll).toArray();

Actions #1

Updated by Daniel Tsviatkov about 14 years ago

Even better would be if update the whole lib for next version

Actions #2

Updated by Jean-Baptiste Barth almost 14 years ago

  • Affected version (unused) changed from 1.1.2 to 1.2.0
  • Resolution deleted (Fixed)
  • Affected version changed from 1.1.2 to 1.2.0

As far as I know, prototype and scriptaculous are in the versions that ship with rails 2.3.11. I don't think we should patch it directly, or the patch will be lost with the next rails upgrade... Any idea if it's solved in rails 3.x ?

Actions #3

Updated by Etienne Massip almost 14 years ago

Jean-Baptiste Barth wrote:

As far as I know, prototype and scriptaculous are in the versions that ship with rails 2.3.11.

I'm not sure about this : Prototype has been upgraded to 1.7 for IE9 compatibility concerns and this may be a version more recent than the one shipped with RoR 2.3.11, and on the other hand, I'm not sure scriptaculous has even been upgraded to fit RoR's version.

Actions #4

Updated by Jean-Baptiste Barth almost 14 years ago

You're right : Rails 2.3.11 ships with Prototype 1.6.x. Anyway, dragdrop.js is identical...

Actions #5

Updated by Toshi MARUYAMA about 11 years ago

  • Status changed from New to Closed

prototype was dropped by r10068.

Actions

Also available in: Atom PDF