Project

General

Profile

Actions

Defect #8139

closed

p.push is not an object in dragdrop.js @379

Defect #8139: p.push is not an object in dragdrop.js @379

Added by Daniel Tsviatkov over 15 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Gantt
Target version:
-
Resolution:
Affected version:

Description

the patch should look like this
@line 376 of dragdrop.js

---p = Position.page(this.options.scroll);
+++p = Position.page(this.options.scroll).toArray();

Updated by Daniel Tsviatkov over 15 years ago Actions #1

Even better would be if update the whole lib for next version

Updated by Jean-Baptiste Barth over 15 years ago Actions #2

  • Affected version (unused) changed from 1.1.2 to 1.2.0
  • Resolution deleted (Fixed)
  • Affected version changed from 1.1.2 to 1.2.0

As far as I know, prototype and scriptaculous are in the versions that ship with rails 2.3.11. I don't think we should patch it directly, or the patch will be lost with the next rails upgrade... Any idea if it's solved in rails 3.x ?

Updated by Etienne Massip over 15 years ago Actions #3

Jean-Baptiste Barth wrote:

As far as I know, prototype and scriptaculous are in the versions that ship with rails 2.3.11.

I'm not sure about this : Prototype has been upgraded to 1.7 for IE9 compatibility concerns and this may be a version more recent than the one shipped with RoR 2.3.11, and on the other hand, I'm not sure scriptaculous has even been upgraded to fit RoR's version.

Updated by Jean-Baptiste Barth over 15 years ago Actions #4

You're right : Rails 2.3.11 ships with Prototype 1.6.x. Anyway, dragdrop.js is identical...

Updated by Toshi MARUYAMA over 12 years ago Actions #5

  • Status changed from New to Closed

prototype was dropped by r10068.

Actions

Also available in: PDF Atom