Defect #8139
closed
p.push is not an object in dragdrop.js @379
Added by Daniel Tsviatkov about 14 years ago.
Updated about 11 years ago.
Description
the patch should look like this
Line Bourdages 376 of dragdrop.js
---p = Position.page(this.options.scroll);
+++p = Position.page(this.options.scroll).toArray();
Even better would be if update the whole lib for next version
- Affected version (unused) changed from 1.1.2 to 1.2.0
- Resolution deleted (
Fixed)
- Affected version changed from 1.1.2 to 1.2.0
As far as I know, prototype and scriptaculous are in the versions that ship with rails 2.3.11. I don't think we should patch it directly, or the patch will be lost with the next rails upgrade... Any idea if it's solved in rails 3.x ?
Jean-Baptiste Barth wrote:
As far as I know, prototype and scriptaculous are in the versions that ship with rails 2.3.11.
I'm not sure about this : Prototype has been upgraded to 1.7 for IE9 compatibility concerns and this may be a version more recent than the one shipped with RoR 2.3.11, and on the other hand, I'm not sure scriptaculous has even been upgraded to fit RoR's version.
You're right : Rails 2.3.11 ships with Prototype 1.6.x. Anyway, dragdrop.js is identical...
- Status changed from New to Closed
prototype was dropped by r10068.
Also available in: Atom
PDF