Patch #826
Fix browsing mercurial repositories
Status: | Closed | Start date: | 2008-03-11 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | SCM | |||
Target version: | 0.7 |
Description
Running redmine on linux, I wasn't able to browse a mercurial repository.
Listing entries usinghg locate
:
- should use '/' to split entries path, not '\' ('\\').
- should filter files with
glob:**
. Restricting paths to a depth of 2 does not work for deep repository trees like :README images/delete.png images/edit.png sources/deep/tree/few/files.txt sources/watchers_controller.rb
Associated revisions
Fixes Mercurial browsing under unix-like os and for directory depth > 2 and (patch #826 by Frederic Moulins, slightly edited to preserve win32 compatibility).
History
#1
Updated by Thomas Lecavelier about 14 years ago
Patch successfully used by a user: http://www.redmine.org/boards/2/topics/show/26
#2
Updated by Jean-Philippe Lang about 14 years ago
Thanks for pointing out this problem.
I made slight changes to your patch to preserve win32 compatibility and committed it in r1228.
Here are the changes:
cmd << " 'glob:**'"
=> (makes it work under win32, but not sure for *nix)
cmd << " glob:**"
and
e = line.chomp.split('/')
=>
e = line.chomp.split(%r{[\/\\]})
Please, let me know if the first change is not ok.
#3
Updated by Jean-Philippe Lang about 14 years ago
- Status changed from New to Resolved
In r1229, glob:**
is quoted properly depending on the os.
It should work fine on both *nix and win32 os.
#4
Updated by Frédéric Moulins about 14 years ago
Works very well for me.
Thanks for the clarification !
#5
Updated by Jean-Philippe Lang about 14 years ago
- Status changed from Resolved to Closed