Project

General

Profile

Actions

Patch #8414

closed

time_entry is saved even with errors

Added by Francisco José Martínez almost 13 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Issues
Target version:
-
Start date:
2011-05-20
Due date:
% Done:

0%

Estimated time:

Description

I don't know if this is already fixed, I'm looking for and no result has been found.

We have a custom field at beginning isn't require, passed few time, we changed this behaviour. some issues hadn't got defined a value for this custom field.
If we try to update the issue, we puts some hours in the field spent_time, but don't put any value in the custom field required then submit.

We have a error, but the time_entry don't have rollback

I'm using redmine 1.0.2 (stable)
I've patched the Issue::save_issue_with_child_records adding a "raise" if "params"
isn't valid


Files

issue.rb.patch (348 Bytes) issue.rb.patch Francisco José Martínez, 2011-05-20 14:09
issue.rb.patch (757 Bytes) issue.rb.patch More lines to compare Francisco José Martínez, 2011-05-20 14:13
Actions #2

Updated by Francisco José Martínez over 12 years ago

  • % Done changed from 100 to 0
Actions #3

Updated by Go MAEDA over 7 years ago

  • Status changed from New to Closed

I cannot reproduce the problem in the current trunk (r16111).
Probably fixed in r8891, source:trunk/app/models/issue.rb@8891#L698 (Redmine 1.4.0).

Actions

Also available in: Atom PDF