Actions
Patch #9102
closedDry up MailHandler logging
Patch #9102:
Dry up MailHandler logging
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Description
Attached patch removes duplicated checks on logger presence in the MailHandler. Also, running "if logger && logger.info" seems to be a dumb thing and adds spurious empty log lines.
The fix is to make logger call always return a non-nil object, even when logger is set to nil in the environment configuration file (a default in production.) It might be good to include into Rails itself, so you never need to write another "if logger" line.
Files
Updated by Etienne Massip about 15 years ago
- Category set to Code cleanup/refactoring
Updated by Go MAEDA almost 11 years ago
- Related to Defect #14598: Wrong test with logger.info in model mail_handler added
Updated by Go MAEDA over 7 years ago
- Status changed from New to Closed
Fixed in r18069.
Actions