Defect #14598: Wrong test with logger.info in model mail_handler - Redmine

Defect #14598

Wrong test with logger.info in model mail_handler

Added by Jérôme BATAILLE over 5 years ago. Updated about 5 years ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

% Done:

Category:

Email receiving

Target version:

2.4.0

Resolution:

Fixed

Affected version:

RM_mail_handler_bug_fix.diff (2.95 KB) Jérôme BATAILLE, 2013-08-01 15:33

Related issues

Associated revisions

Revision 12073
Added by Toshi MARUYAMA over 5 years ago

remove ineffective "logger.info" and "logger.error" check from MailHandler model (#14598)

History

#1 Updated by Jérôme BATAILLE over 5 years ago

patch made against Redmine V1.2.1

if logger.info --> if logger.info?

#2 Updated by Toshi MARUYAMA over 5 years ago

"logger.info" is always true.

$ RAILS_ENV=test ruby script/rails console
Loading test environment (Rails 3.2.13)
1.9.3p429 :001 > logger = Logger.new(STDOUT)
 => #<Logger:0x000000055b5b80 ... 
1.9.3p429 :002 > logger.level = Logger::ERROR
 => 3 
1.9.3p429 :003 > logger.info
 => true 
1.9.3p429 :004 > logger.info?
 => false 
1.9.3p429 :005 > logger.info "test" 
 => true 
1.9.3p429 :006 > logger.level = Logger::INFO
 => 1 
1.9.3p429 :007 > logger.info?
 => true 
1.9.3p429 :008 > logger.info
nil
 => true 
1.9.3p429 :009 > logger.info "test" 
test
 => true