Project

General

Profile

Actions
Copy link

Defect #9128

closed

Redmine sugestion of the git repository path is incorrect

Added by Tomas Pospisek over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2011-08-25
Due date:
% Done:

0%

Estimated time:
Resolution:
Invalid
Affected version:

Description

See http://www.redmine.org/boards/2/topics/25889

Redmine suggests that the path to the git repository should look like this:

"Bare and local repository (e.g. /gitrepo, c:\gitrepo)"

however that will result in a weird error (see the Forum thread above), when in reality the path should look like this instead:

"Bare and local repository (e.g. /gitrepo/.git, c:\gitrepo\.git)"

I'd suggest to fix the code and automatically add the ".git" when it's missing, aka in lib/redmine/scm/adapters/git_adapter.rb in the function scm_cmd I suggest to do:

full_args = [GIT_BIN, '--git-dir', (repo_path =~ /\.git$/ ?  repo_path : File.join(repo_path, '.git') ) ]

instead.

I can't understand how Redmine users would succeed to access their git repos from Redmine in the past without loosing hald of their hair?

Related issues

Related to Redmine - Patch #9129: Improve wording of Git repository note at project settingClosedToshi MARUYAMA2011-08-26

Actions
Actions
Copy link

Also available in: Atom PDF