Redmine

Test cases are missing. I know it wouldn't be easy but you can try to accept "not so remote" repository in tmp dir.

Not tested, but the dir variable in the diff could break if white spaces appear: please protect this var expansion in the command line with simple quotes.

Toshi MARUYAMA wrote:

As I described #7494 note 2,
I think Redmine core should not have this feature.
It is impossible to test.
Plugins should provide this feature.

It is not impossible, it can be a little tricky, but still really possible. A easy test case could be: get a dummy git bare repository in the test folder, then run git-daemon configured to provide this dummy repository. The unit test will have to add a repository from git://localhost/1.git (for example) and then check to see if the folder was correctly created and if it's a git repository.

Also there is the "git" rubygem that can make it easy to clone and fetch revisions:

require 'git'
Git.clone('git://github.com/.../repo.git', '/destination/path.git', :bare => true)

and

git = Git.open('/destination/path.git', :log => Logger.new(STDOUT))
git.fetch('origin')

It can't be easier then that. Implementing this "feature" will make redmine usable with git.