Feature #11109

Repository Identifier should be frozen

Added by Jan from Planio www.plan.io over 5 years ago. Updated over 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:SCM
Target version:2.1.0
Resolution:Fixed

Description

I'd like to suggest/discuss the idea of "freezing" the repository identifier just like it's done for the project identifier, i.e. after a project has been created, the identifier cannot be changed anymore.

From what I understand in the comments to #779, the identifier is used in URLs and for wiki links. Both would benefit from the identifier being frozen like for projects as this would prevent users from inadvertently breaking existing links.

What do you think? Would be happy to provide a patch if you share my opinion.

frozen_repository_identifiers.patch Magnifier (47.9 KB) Jan from Planio www.plan.io, 2012-06-21 19:15

Associated revisions

Revision 10081
Added by Jean-Philippe Lang over 5 years ago

Repository Identifier should be frozen (#11109).

History

#1 Updated by Etienne Massip over 5 years ago

  • Target version set to Candidate for next major release

#2 Updated by Jan from Planio www.plan.io over 5 years ago

Is that a +1? :-)

#3 Updated by Etienne Massip over 5 years ago

It's my +1, yes =)

#4 Updated by Ivan Cenov over 5 years ago

Is it possible 'frozen' to be configurable in a checkbox at project or at Redmine level?

#5 Updated by Etienne Massip over 5 years ago

Ivan Cenov wrote:

Is it possible 'frozen' to be configurable in a checkbox at project or at Redmine level?

Why so?

#6 Updated by Jan from Planio www.plan.io over 5 years ago

I don't think it would make sense to make this a configurable setting. In my point of view, changing identifiers after a repo has been created can lead to broken links and confusion among users. I don't see a benefit of having changeable identifiers, so I'd say no configuration option.

#7 Updated by Jan from Planio www.plan.io over 5 years ago

Here's a patch against current trunk (r9879). Most of it is taken directly from the corresponding code for project identifiers. What do you think?

#8 Updated by Etienne Massip over 5 years ago

Jan from Planio www.plan.io wrote:

Here's a patch against current trunk (r9879). Most of it is taken directly from the corresponding code for project identifiers. What do you think?

Looks fine to me.

#9 Updated by Jean-Philippe Lang over 5 years ago

  • Target version changed from Candidate for next major release to 2.1.0

#10 Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch applied with slight changes in r10081.

Also available in: Atom PDF