Redmine

That would be really useful functionality because it will allow us to use redmine wiki as project documentation source. Especially with redmine_pdf_documents plug-in available.

But redmine_pdf_documents doesn't work in 2.x

Yes the 2.x branach is
https://github.com/klausmeyer/redmine_pdf_documents/commit/3b7e464098484d0af7e61583adbbd6c8dac276ac

Thanks, README is misleading becuase is read there is no redmine 2.x port

+1

The redmine_pdf_wiki plugin uses wkhtml2pdf to export pdf and promises to resolve macros.
A big disadavantge is that it's only runny on passenger.

#14412 - Wiki > Textile text with hidden part not correctly exported to pdf should be listed in the related issues

Patch from Note-12 causes error 500 on issue and Wiki PDF export (Redmine 2.3.1 and Redmine 2.3.3). Logs:

• Issue export
  

  NoMethodError (undefined method `truncate' for #<Redmine::Export::PDF::ITCPDF:0xbfbe9f0>):
    app/helpers/application_helper.rb:697:in `block in parse_redmine_links'
    app/helpers/application_helper.rb:666:in `gsub!'
    app/helpers/application_helper.rb:666:in `parse_redmine_links'
    app/helpers/application_helper.rb:513:in `block (2 levels) in textilizable'
    app/helpers/application_helper.rb:512:in `each'
    app/helpers/application_helper.rb:512:in `block in textilizable'
    app/helpers/application_helper.rb:533:in `parse_non_pre_blocks'
    app/helpers/application_helper.rb:511:in `textilizable'
    lib/redmine/export/pdf.rb:118:in `formatted_text'
    lib/redmine/export/pdf.rb:144:in `RDMwriteHTMLCell'
    lib/redmine/export/pdf.rb:668:in `block in issue_to_pdf'
    lib/redmine/export/pdf.rb:660:in `issue_to_pdf'
    app/controllers/issues_controller.rb:124:in `block (2 levels) in show'
    app/controllers/issues_controller.rb:116:in `show'
  

• Wiki export
  

  NoMethodError (undefined method `strip_tags' for #<Redmine::Export::PDF::ITCPDF:0xcaf7254>):
    app/helpers/application_helper.rb:821:in `block in parse_headings'
    app/helpers/application_helper.rb:819:in `gsub!'
    app/helpers/application_helper.rb:819:in `parse_headings'
    app/helpers/application_helper.rb:516:in `textilizable'
    lib/redmine/export/pdf.rb:118:in `formatted_text'
    lib/redmine/export/pdf.rb:144:in `RDMwriteHTMLCell'
    lib/redmine/export/pdf.rb:769:in `write_wiki_page'
    lib/redmine/export/pdf.rb:749:in `wiki_page_to_pdf'
    app/controllers/wiki_controller.rb:83:in `show'
  

Yes Yurii I found that problem and much more. it turned out that it was not straight forward. I have made significant progress to enable the PDF rendering to use textilizable but it is not there yet(wiki links are not parsed and some internal errors are still not solved) if you are in a hurry I can drop here the in progress patch, maybe you could finish it. I am sorry I have not given the follow up but I have been very busy.

After some investigation I concluded that the problem with the crashes was due to text.html_safe in the textilizable method.

    if @parsed_headings.any?
      replace_toc(text, @parsed_headings)
    end

    text.html_safe

  end

I found that the problem described above (CGI.unescapeHTML not failing) is really weird, because if I apply html_safe to the text and then perform a "cast" to force the SafeBuffer no error is triggered. On the other hand, even when calling CGI.unescapeHTML on an object returned by to_s method, an error is triggered. It should be noted that the to_s method simply returns self, so it is maybe expected that it's calling is redundant, and obviously would trigger the error just as a normal SafeBuffer would.

The solution I found was to keep everything unchanged in textilizable but performing a hard string cast, string interpolation in the formatted_text(text) method in pdf.rb

Finally I was able to reproduce and definitely confirm the error in the Rails console:

CGI.unescapeHTML('The experimental macro Hello Latex["\"sdsd\""'.html_safe)

I will now report it to the Rails mailing list to hear their opinion.

The last problem standing is the links to the Wikis embedded in the pdf. I don't know yet why they are not working but I will play with the Rails console to expedite the resolution of the problem. Afterwards I believe a patch is ready, and the tests should be generated.

Hi Paulo, is there any progress with your patch?

https://github.com/redmine/redmine/pull/48

diff --git a/lib/redmine/export/pdf.rb b/lib/redmine/export/pdf.rb
index 00c6d13..67b0c8f 100644
--- a/lib/redmine/export/pdf.rb
+++ b/lib/redmine/export/pdf.rb
@@ -62,7 +62,9 @@ def formatted_text(text)
           html = Redmine::WikiFormatting.to_html(Setting.text_formatting, text)
           # Strip {{toc}} tags
           html.gsub!(/<p>\{\{([<>]?)toc\}\}<\/p>/i, '')
-          html
+      # Strip {{collapse()}} tags
+      html.gsub!(/\{\{collapse\((.*)?\)([^}]*)?\}\}/,'\1 \2')
+      html
         end

         def RDMCell(w ,h=0, txt='', border=0, ln=0, align='', fill=0, link='')
</class>

+1

Please testing include macro, the bug have not been fixed, I am using 2.6.0 stable version.