Project

General

Profile

Actions

Defect #14817

closed

Redmine loses filters after deleting a spent time

Added by Thomas Godard over 10 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Time tracking
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When you add filters in the spent time "Details" view, and then delete an entry, the refresh loses the filters you had.

Steps to reproduce:
  • Add a filter
  • Delete a spent time

Expected result:

Refresh with the filter you had

Actual result:

Refresh with the default page


Files


Related issues

Related to Redmine - Defect #13622: "Clear" button in Spent Time Report tab also clears global filtersClosedJean-Philippe Lang

Actions
Related to Redmine - Defect #17302: Forwarding from issues time entries page to project time entries pageClosed

Actions
Has duplicate Redmine - Defect #9016: displayed page after deleting time_entryClosed2011-08-09

Actions
Actions #1

Updated by Marius BĂLTEANU over 7 years ago

This issue reproduces also on the latest trunk version.

Actions #2

Updated by Marius BĂLTEANU over 7 years ago

I think that this issue is generated by another issue: time spent filters are not stored in the session.

To reproduce:

  1. Go to the spent time tab
  2. Create a filter
  3. Navigate to issues tab
  4. Return to the spent time tab
  5. Observe that the filters are reseted.
Actions #3

Updated by Marius BĂLTEANU over 7 years ago

The below change seems to fix the issue. I'm going to make a patch with tests for this.

diff --git a/app/controllers/timelog_controller.rb b/app/controllers/timelog_controller.rb
old mode 100644
new mode 100755
index 6c0cd3e..2edf556
--- a/app/controllers/timelog_controller.rb
+++ b/app/controllers/timelog_controller.rb
@@ -281,6 +281,6 @@ private
   end

   def retrieve_time_entry_query
-    retrieve_query(TimeEntryQuery, false)
+    retrieve_query(TimeEntryQuery, true)
   end
 end
Actions #4

Updated by Marius BĂLTEANU over 7 years ago

Attached is a patch that fixes the issue reported initially in this ticket and the issue from note-2. Please let me know if a should open a new ticket for the issue from note-2.

Actions #5

Updated by Go MAEDA over 7 years ago

  • Target version set to 3.3.2

Thank you for the patch, it works fine for me and passed all tests.
In addition, the patch also fixes #13622.

Setting target version to 3.3.2.

Actions #6

Updated by Go MAEDA over 7 years ago

  • Related to Defect #13622: "Clear" button in Spent Time Report tab also clears global filters added
Actions #7

Updated by Jean-Philippe Lang over 7 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Marius BALTEANU wrote:

Attached is a patch that fixes the issue reported initially in this ticket and the issue from note-2. Please let me know if a should open a new ticket for the issue from note-2.

Storing the filters in session is a different behaviour, please open another ticket and we'll see if this is desirable, thanks.
I've have the reported issue in r16056 without changing this behaviour.

Actions #8

Updated by Marius BĂLTEANU over 7 years ago

Jean-Philippe Lang wrote:

Marius BALTEANU wrote:

Attached is a patch that fixes the issue reported initially in this ticket and the issue from note-2. Please let me know if a should open a new ticket for the issue from note-2.

Storing the filters in session is a different behaviour, please open another ticket and we'll see if this is desirable, thanks.
I've have the reported issue in r16056 without changing this behaviour.

Here is the new ticket #24581.

Actions #9

Updated by Jean-Philippe Lang over 7 years ago

  • Subject changed from Redmine loses filters after deleting a spent time. to Redmine loses filters after deleting a spent time
  • Status changed from Resolved to Closed
Actions #10

Updated by Go MAEDA over 7 years ago

  • Has duplicate Defect #9016: displayed page after deleting time_entry added
Actions #11

Updated by Marius BĂLTEANU about 6 years ago

  • Related to Defect #17302: Forwarding from issues time entries page to project time entries page added
Actions

Also available in: Atom PDF