Defect #13622

"Clear" button in Spent Time Report tab also clears global filters

Added by Anton Nepomnyaschih over 4 years ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Time tracking
Target version:3.3.2
Resolution:Fixed Affected version:

Description

Steps to reproduce:
1. Go to Projects -> Overall spent time -> Report.
2. Add some filters or just choose "Date is today".
3. Click Clear in Details area.

Expected result:
Only report itself is cleared.

Actual result:
Filters are cleared too. Look at the following screencast: http://screencast.com/t/VCs06HqDfP

fix.js (252 Bytes) Artyom Khramov, 2014-12-11 10:21


Related issues

Related to Redmine - Defect #14817: Redmine loses filters after deleting a spent time Closed
Duplicated by Redmine - Defect #17724: Time Entries Report: Reset links behave inconsistent Closed

Associated revisions

Revision 16057
Added by Jean-Philippe Lang 7 months ago

"Clear" button in Spent Time Report tab also clears global filters (#13622).

History

#1 Updated by Etienne Massip over 4 years ago

  • Status changed from New to Needs feedback

I don't get it:

  • details and filters are supposed to be synced, what would mean clearing the details only??
  • it works in time tracking report the same way it works in issue list
  • the Clear link is not located within the Details tab

#2 Updated by Anton Nepomnyaschih over 4 years ago

Please, look here: http://screencast.com/t/Bz2eAFz0x I call the area on the top as "Filters area". And area on the bottom as "Details area".

I think, workflow of the page is next:
1. User configurates Filters. He can choose any filters he want.
2. User selects "Details" combobox (Month, Year, Week, etc.). And the user Adds any thing he wants to see spent time by.

After that he can change his choice and to choose another period, for example, month. Or choose another granilarity (for example, by issues, not by tracker). And it mustn't change filters above. But now user can't just change the granularity and choose another breakdown - when he clicks Clear, it also clears all filters. So he has to select the filters again.

#3 Updated by Anton Nepomnyaschih over 4 years ago

Please, also look at the video I provided in description of the ticket.

#4 Updated by Etienne Massip over 4 years ago

  • Subject changed from "Clear" in Spent Time Report clears Filters also to "Clear" button in Spent Time Report tab also clears global filters
  • Category set to Time tracking
  • Status changed from Needs feedback to Confirmed
  • Target version set to Candidate for next minor release

I can't watch your video right now but I can confirm the bug, I thought you were talking about the Details tab but you were actually talking about the Details filter in the Report tab.

My bad.

#5 Updated by Artyom Khramov over 2 years ago

Here's a js script that will fix this defect. Just include it into your project.

#6 Updated by Zer Guz almost 2 years ago

+1 Please make this easy fix in Redmine as soon as possible. As it is now, it is hassle to re-enter the global filters every time I have to clear the report.

#7 Updated by Nick Sneg almost 2 years ago

Artyom Khramov wrote:

Here's a js script that will fix this defect. Just include it into your project.

What does it mean, how to include this script to my redmine server?

#8 Updated by mouson chen 8 months ago

+1

#9 Updated by Go MAEDA 7 months ago

  • Related to Defect #14817: Redmine loses filters after deleting a spent time added

#10 Updated by Go MAEDA 7 months ago

  • Target version changed from Candidate for next minor release to 3.3.2

This issue can be fixed by the patch attached on #14817#note-4.
Setting target version to 3.3.2 along with #14817.

#11 Updated by Go MAEDA 7 months ago

  • Duplicated by Defect #17724: Time Entries Report: Reset links behave inconsistent added

#12 Updated by Jean-Philippe Lang 7 months ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r16057 without storing filters in session.
Thanks for pointing this out.

#13 Updated by Jean-Philippe Lang 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF