Patch #18290

Issue performance patch

Added by Ondřej Ezr almost 4 years ago. Updated almost 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:3.0.0

Description

Issue safe_attribute 'is_private' cause a author loading if not necessary in some situations, and status_id_was is same as status_id, and it is not preventing loading if not changed.

Please accept, I hate patch all method, cuz one line change :(

issue_performance.diff Magnifier (1.17 KB) Ondřej Ezr, 2014-11-06 10:16


Related issues

Duplicated by Redmine - Patch #17880: Performance issues on Issue model Closed

Associated revisions

Revision 13576
Added by Jean-Philippe Lang almost 4 years ago

Prevents author load (#18290).

Patch by Ondřej Ezr.

Revision 13577
Added by Jean-Philippe Lang almost 4 years ago

Prevents a status load in #status_was when status is not changed (#18290).

History

#1 Updated by Mischa The Evil almost 4 years ago

  • Category set to Code cleanup/refactoring

#2 Updated by Jean-Philippe Lang almost 4 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.0.0

The author load fix is committed in r13576.

The second part is not OK and breaks a bunch of tests because #status_was would return nil if status was not changed, where it should return the current status. Fixed in r13577.

The last part is no longer in sync with trunk.

Thanks for your submission.

#3 Updated by Go MAEDA almost 3 years ago

  • Duplicated by Patch #17880: Performance issues on Issue model added

Also available in: Atom PDF