Defect #19403

Mistake in Polish Translation file.

Added by Maciej G. over 3 years ago. Updated about 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Translations
Target version:3.2.0
Resolution:Fixed Affected version:

Description

In Polish Translation (config/locale/pl.yml) file there is mistake (at least) in two keys repeated in all recent versions of Redmine includeing 3.0.1.

Two values need to be changed because of inproper use of the variables %{count} and %{count}.

They corrected values shoud look like:

mail_subject_reminder: "Uwaga na terminy, masz zagadnienia do obsłużenia w ciągu następnych %{days} dni! (%{count})" 
mail_body_reminder: "Wykaz przypisanych do Ciebie zagadnień, których termin wypada w ciągu następnych %{days} dni" 

Discovered that mistake with my workmate.

pl-19403.diff Magnifier (1.39 KB) Go MAEDA, 2015-03-17 09:49


Related issues

Related to Redmine - Patch #2001: Fresh polish translation Closed 2008-10-07
Duplicated by Redmine - Defect #8287: Polish e-mail due task notifications Closed 2011-05-04

Associated revisions

Revision 14639
Added by Jean-Philippe Lang about 3 years ago

Mistake in Polish Translation file (#19403).

Patch by Sebastian Paluch.

History

#1 Updated by Go MAEDA over 3 years ago

I made a patch file from the description.

#2 Updated by Go MAEDA over 3 years ago

  • Duplicated by Defect #8287: Polish e-mail due task notifications added

#3 Updated by Toshi MARUYAMA over 3 years ago

  • Target version set to 3.1.0

#4 Updated by Toshi MARUYAMA over 3 years ago

  • Related to Patch #2741: Polish translation for r2460 added

#5 Updated by Toshi MARUYAMA over 3 years ago

  • Related to deleted (Patch #2741: Polish translation for r2460)

#6 Updated by Toshi MARUYAMA over 3 years ago

  • Related to Patch #2001: Fresh polish translation added

#7 Updated by Toshi MARUYAMA over 3 years ago

source:trunk/lang/en.yml@1928#L97

mail_body_reminder: "%d issue(s) that are assigned to you are due in the next %d days:" 

#8 Updated by Toshi MARUYAMA over 3 years ago

  • Status changed from New to Needs feedback
  • Target version deleted (3.1.0)

Polish "mail_body_reminder" %{count} parameter was removed by r1928 (#2001).
Could you add %{count} parameter to Polish "mail_body_reminder"?

source:trunk/config/locales/en.yml@14180#L217

mail_body_reminder: "%{count} issue(s) that are assigned to you are due in the next %{days} days:" 

#9 Updated by Toshi MARUYAMA over 3 years ago

I think "mail_subject_reminder" is correct due to r3907 change.

--- pl.yml    (revision 3906)
+++ pl.yml    (revision 3907)
@@ -640,7 +640,7 @@
   mail_subject_account_activation_request: "Zapytanie aktywacyjne konta {{value}}" 
   mail_subject_lost_password: "Twoje hasło do {{value}}" 
   mail_subject_register: "Aktywacja konta w {{value}}" 
-  mail_subject_reminder: "Uwaga na terminy, masz zagadnienia do obsłużenia w ciągu następnych {{count}} dni!" 
+  mail_subject_reminder: "Uwaga na terminy, masz zagadnienia do obsłużenia w ciągu następnych {{count}} dni! ({{days}})" 
   notice_account_activated: Twoje konto zostało aktywowane. Możesz się zalogować.
   notice_account_invalid_creditentials: Zły użytkownik lub hasło
   notice_account_lost_email_sent: Email z instrukcjami zmiany hasła został wysłany do Ciebie.

What do you think?

#10 Updated by Sebastian Paluch about 3 years ago

Toshi MARUYAMA wrote:

I think "mail_subject_reminder" is correct due to r3907 change.

[...]

What do you think?

The r3907 is wrong. Correct translation is specified in the description.

#11 Updated by Toshi MARUYAMA about 3 years ago

Sebastian Paluch wrote:

Toshi MARUYAMA wrote:

I think "mail_subject_reminder" is correct due to r3907 change.

[...]

What do you think?

The r3907 is wrong. Correct translation is specified in the description.

Thank you. Could you give us correct "mail_body_reminder"?

#12 Updated by Sebastian Paluch about 3 years ago

Toshi MARUYAMA wrote:

Thank you. Could you give us correct "mail_body_reminder"?

Taking under consideration many plural forms used in Polish I would suggest to keep %{count} in brackets.
...and making it closer to original English version I would propose:

mail_subject_reminder: "Zagadnienia (%{count}) do obsłużenia w ciągu następnych %{days} dni" 
mail_body_reminder: "Wykaz przypisanych do Ciebie zagadnień (%{count}), których termin dobiega końca w ciągu następnych %{days} dni:" 

It seems there is much more stuff that needs translation. I will try to find time to do this.

#13 Updated by Toshi MARUYAMA about 3 years ago

  • Status changed from Needs feedback to New

#14 Updated by Toshi MARUYAMA about 3 years ago

  • Target version set to 3.2.0

#15 Updated by Sebastian Paluch about 3 years ago

I have added updated translation in #20785.

#16 Updated by Jean-Philippe Lang about 3 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Change committed in r14639, thanks.

Also available in: Atom PDF