Patch #20271

Fix for multiple tabs on the same page

Added by Felix Gliesche over 3 years ago. Updated about 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.0

Description

When navigation tabs use more space than their container (e.g. /settings), tab buttons are displayed in order to horizontally scroll to non visible tabs.

The javascript function (in application.js) displayTabButtons takes care of settting these tab buttons to a visible / non-visible state. This function is theoretically supposed to work for severeal tab navigations. It applies it's logic to all divs, with class .tabs in a for each loop.

To my knowledge redmine does not have pages with several of these tab navigations. If a plugins tries to use this funtionality, though, it will run into the following problem: If one tab navigation meets the condition to be displayed, all other tab navigations on the page (even when not needed) will have the tab buttons for horizontal scrolling enabled.

This patch fixes this false behaviour.

0001-Fix-display-tab-function-for-more-than-one-set-of-ta.patch Magnifier (921 Bytes) Felix Gliesche, 2015-07-08 12:44


Related issues

Related to Redmine - Patch #20906: Fix mulitple tab navigation highlighting and content hiding Closed
Blocks Redmine - Patch #20632: Tab left/right buttons for project menu Closed

Associated revisions

Revision 14624
Added by Jean-Philippe Lang about 3 years ago

Fix for multiple tabs on the same page (#20271).

Patch by Felix Gliesche.

History

#1 Updated by Jan from Planio www.plan.io over 3 years ago

  • Subject changed from Fix for multible tab navigations to Fix for multiple tab navigations
  • Target version set to Candidate for next minor release

#2 Updated by Toshi MARUYAMA about 3 years ago

  • Target version changed from Candidate for next minor release to 3.2.0

#3 Updated by Jan from Planio www.plan.io about 3 years ago

  • Blocks Patch #20632: Tab left/right buttons for project menu added

#4 Updated by Jean-Philippe Lang about 3 years ago

  • Subject changed from Fix for multiple tab navigations to Fix for multiple tabs on the same page
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed in r14624, thanks.

#5 Updated by Jan from Planio www.plan.io about 3 years ago

  • Related to Patch #20906: Fix mulitple tab navigation highlighting and content hiding added

Also available in: Atom PDF