Patch #20632

Tab left/right buttons for project menu

Added by Felix Gliesche about 2 years ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.3.0

Description

On small screens with many tabs in the project navigation the tabs of the far right are not visible. It would be nice if the tabs can be scrolled left / right like in the second level navigation (e.g. project settings).

This patch introduces this feature. It uses the same javascript as the second level navigation.

In order for this to work, you need the the patch attached to #20271

Settings - Project A - Redmine 2015-08-28 17-34-26.png (127 KB) Jan from Planio www.plan.io, 2015-08-28 17:35

0001-Apply-existing-tab-functionality-to-main-menu.patch Magnifier (4.56 KB) Felix Gliesche, 2015-09-01 19:18

0002-Tab-buttons-add-some-user-feedback.patch Magnifier (4.04 KB) Daniel Ritz, 2016-01-25 22:39

tabbuttons-left-not-possbile.png - Screenshot (17.8 KB) Daniel Ritz, 2016-01-25 22:45


Related issues

Related to Redmine - Patch #13892: Wraping Mainmenu on long menus Closed
Related to Redmine - Defect #9275: If the number of modules spans over 2 lines, ugly overlap... Closed 2011-09-19
Related to Redmine - Defect #6624: Project horizontal menu layout doesn't wrap Closed 2010-10-11
Blocked by Redmine - Patch #20271: Fix for multiple tabs on the same page Closed

Associated revisions

Revision 15067
Added by Jean-Philippe Lang almost 2 years ago

Tab left/right buttons for project menu (#20632).

Patch by Felix Gliesche.

Revision 15249
Added by Jean-Philippe Lang over 1 year ago

Tab-buttons: add some user-feedback (#20632).

  • Hover color
  • Enable/disable buttons (visually at least) when no more change is possible
  • Width calculation with jQuery only, no longer hard-coded
  • Remove ugly outline in Chrome (at least on Mac)

Patch by Daniel Ritz.

History

#1 Updated by Jan from Planio www.plan.io about 2 years ago

  • Blocked by Patch #20271: Fix for multiple tabs on the same page added

#2 Updated by Jan from Planio www.plan.io about 2 years ago

Here's a screenshot to illustrate this.

Settings - Project A - Redmine 2015-08-28 17-34-26.png

#3 Updated by Felix Gliesche about 2 years ago

For this patch to work, we need inline-block elements instead of left floating elements. I am uploading a little update to the initial patch, that fixes the problem of space between inline-block elements (see problem and solutions to it here: https://css-tricks.com/fighting-the-space-between-inline-block-elements/) by removing new lines between the project menu's list elements.

#4 Updated by Jan from Planio www.plan.io about 2 years ago

  • File deleted (0001-Apply-existing-tab-functionality-to-main-menu.patch)

#5 Updated by Jan from Planio www.plan.io about 2 years ago

Just removed the old patch version

#6 Updated by Go MAEDA almost 2 years ago

  • Target version set to 3.3.0

The patch can be applied cleanly to the current trunk (r14989) and works fine.
Maybe overflowed main menu have annoyed many users. Let's include this feature in Redmine 3.3.0.

#7 Updated by Go MAEDA almost 2 years ago

  • Related to Patch #13892: Wraping Mainmenu on long menus added

#8 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed, thanks.

#9 Updated by Daniel Ritz almost 2 years ago

I really like that one! One thing though: how about some user feedback by enabling/disabling the buttons? I hacked together something:
  • Hover color
  • Enable/disable buttons (visually at least) when no more change is possible
  • Width calculation with jQuery only, no longer hard-coded
  • Remove ugly blue outline on buttons in Chrome (at least on Mac)

It's only lightly tested. Please see screenshot (and ignore the collapse-sidebar button, that's from #21808..too lazy to un-apply :)
Screenshot

#10 Updated by Go MAEDA almost 2 years ago

  • Related to Defect #9275: If the number of modules spans over 2 lines, ugly overlapping of controls may occur. added

#11 Updated by Toshi MARUYAMA almost 2 years ago

  • Status changed from Closed to Reopened

Daniel Ritz wrote:

I really like that one! One thing though: how about some user feedback by enabling/disabling the buttons? I hacked together something:

Reopened.

#12 Updated by Jean-Philippe Lang over 1 year ago

  • Status changed from Reopened to Closed

Patch by Daniel committed, thanks.

#13 Updated by Olivier Houdas over 1 year ago

Tabs buttons are now visible on the home page after logging in, when using Redmine 3.3.0 released yesterday. This is a bit confusing, as there are no tabs in the home page.

#14 Updated by Go MAEDA over 1 year ago

Olivier Houdas wrote:

Tabs buttons are now visible on the home page after logging in, when using Redmine 3.3.0 released yesterday. This is a bit confusing, as there are no tabs in the home page.

Since 3.3.0 have been released, please create a new issue to report a defect.

#15 Updated by Olivier Houdas over 1 year ago

Sorry, this is due to RedmineCRM contact_helpdesk plugin. I will file a bug directly to them.

#16 Updated by Go MAEDA 11 months ago

  • Related to Defect #6624: Project horizontal menu layout doesn't wrap added

Also available in: Atom PDF