Defect #20995
closedAutomatic done ratio calculation in issue tree is wrong in some cases
0%
Description
Currently the done ratio of parent issues in an issue tree is calculated based on the average of done ratios of the leaves bellow that issue source:/tags/3.1.1/app/models/issue.rb#L1491. This however can lead to inconsistencies in the automatically calculated done ratios.
For example: issue C with a done ratio of 50% and an open status, which is a subtask of issue B with a done ratio of 70% automatically set by its (open) status, which itself is a subtask of issue A, with a status that doesn't automatically set the done ratio. In that case, A will have an automatically calculated done ratio of 50% because it will be calculated based on the leaf's done ratios, i.e. from C, although its only direct child has a done ratio of 70%.
Is there any rationale to keeping the calculation of the done ratio based on the leaves? I would like to change it to be calculated based on the done ratios of the direct children. If this is an acceptable change I can work on a patch.
Files
Related issues
Updated by Felix Schäfer about 9 years ago
As a side-note: I'm aware of #6609, this is not directly related though.
Updated by Jens Krämer about 9 years ago
- File calculate_done_ratio_from_children_20995.diff calculate_done_ratio_from_children_20995.diff added
here's a patch switching done ratio calculation from the leaves to direct children, and a test illustrating the problem.
Updated by Jean-Philippe Lang almost 9 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Updated by Toshi MARUYAMA about 8 years ago
- Related to Defect #23511: Progress of parent task should be calculated using total estimated hours of children added