Patch #21582
closed
Performance in User#roles_for_project
Added by Ondřej Ezr over 8 years ago.
Updated over 8 years ago.
Description
roles are duplicating a scope not an result, thus every hit produce a query, cached, but it is still not desired.
Files
- Target version set to 3.3.0
I think we can remove the last 'dup' method from Ondřej Ezr's patch because ActiveRecord::Associations::CollectionProxy#to_a returns copied objects.
# File activerecord/lib/active_record/associations/collection_proxy.rb, line 943
def to_ary
load_target.dup
end
true, I just put to_a there with heureka feeling, but you are right dup is meaningless now :)
Thanks for your feedback. Nice eureka!
- Subject changed from Performance in roles to Performance in User#roles_for_project
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by