Patch #21593

Add class to contextual edit button that relates to heading on wiki pages

Added by Felix Gliesche about 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.1

Description

Currently all headings within a .wiki container have the same margins. When changing these margin in a theme, the contextual edit icons do not align with their headings anymore.

This patch adds a class to the contextual edit buttons in order to style them for their corresponding headlines.

0001-Add-class-to-contextual-edit-button-that-relates-to-.patch Magnifier (985 Bytes) Felix Gliesche, 2015-12-23 11:04

Associated revisions

Revision 15136
Added by Jean-Philippe Lang almost 2 years ago

Add class to contextual edit button that relates to heading on wiki pages ().

Patch by Felix Gliesche.

Revision 15137
Added by Jean-Philippe Lang almost 2 years ago

Don't use implicit variables later (#21593).

History

#1 Updated by Jan from Planio www.plan.io about 2 years ago

  • Target version set to Candidate for next minor release

Since this can be generally useful for themes and is a minor change, I'd suggest that for the next minor release.

#2 Updated by Toshi MARUYAMA almost 2 years ago

  • Target version changed from Candidate for next minor release to 3.3.0

#3 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

#4 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from Closed to Resolved
  • Target version changed from 3.3.0 to 3.2.1

3.2.1 will be fine.

#5 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF