Patch #21847

Let mobile header be fixed

Added by Felix Gliesche over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI - Responsive
Target version:3.2.1

Description

It's a common pattern to have a fixed header for mobile devices in order to have important menu points always available instead having to scroll back to top.

This patch makes the header fixed on mobile devices.

21847-calendar.png (45 KB) Go MAEDA, 2016-01-29 09:27

21847-gantt.png (52.6 KB) Go MAEDA, 2016-01-29 09:27

0001-Let-mobile-header-be-fixed.patch Magnifier (1.34 KB) Felix Gliesche, 2016-01-29 15:09


Related issues

Related to Redmine - Feature #24671: Make the header fixed New

Associated revisions

Revision 15204
Added by Jean-Philippe Lang over 2 years ago

Let mobile header be fixed (#21847).

Patch by Felix Gliesche.

History

#1 Updated by Go MAEDA over 2 years ago

Thanks for the improvement!
But I have experienced some z-order related problem in gantt and calendar. please see the following screenshots.

#2 Updated by Felix Gliesche over 2 years ago

Thank you very much for your feedback. I am uploading an updated patch, which fixes the mentioned problems by setting the z-index to a very high value (9999).

#3 Updated by Jan from Planio www.plan.io over 2 years ago

  • File deleted (0001-Let-mobile-header-be-fixed.patch)

#4 Updated by Jan from Planio www.plan.io over 2 years ago

Deleting the obsolete patch.

I was also wondering if this should maybe assigned to the next minor version already? It is not a tremendously big change, more of an incremental improvement of the (already released) responsive layout.

Is it okay if I reassign to next minor instead of major?

#5 Updated by Jan from Planio www.plan.io over 2 years ago

  • Target version changed from Candidate for next major release to Candidate for next minor release

I'm assigning this to next minor, hoping that's okay. A fixed header is a big win for usability since it keeps the sidebar toggle button in sight always. It's also a relatively small patch that should not break anything.

#6 Updated by Toshi MARUYAMA over 2 years ago

  • Target version changed from Candidate for next minor release to 3.2.1

#7 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

#8 Updated by Toshi MARUYAMA over 1 year ago

Also available in: Atom PDF