Patch #22074

Prevent username from overlapping in mobile menu

Added by Felix Gliesche almost 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI - Responsive
Target version:3.2.1

Description

Under certain cirumstances the username shown in the mobile menu can break into another line overlapping the next menu item. For example if the username is too long and contains a '-':

I am attaching a patch which fixes this behaviour by avoiding line breaks and by adding text-overflow: ellipsis

after.png (100 KB) Felix Gliesche, 2016-02-17 23:29

before.png (101 KB) Felix Gliesche, 2016-02-17 23:29

0001-Prevent-username-from-overlapping-in-mobile-menu.patch Magnifier (760 Bytes) Felix Gliesche, 2016-02-17 23:29

0002-Expand-username-to-cover-whole-line-in-mobile-menu.patch Magnifier (744 Bytes) Gregor Schmidt, 2016-02-19 16:06

screen-capture-30.png (16.8 KB) Gregor Schmidt, 2016-02-19 16:07

Associated revisions

Revision 15210
Added by Jean-Philippe Lang almost 3 years ago

Prevent username from overlapping in mobile menu (#22074).

Patch by Felix Gliesche.

Revision 15211
Added by Jean-Philippe Lang almost 3 years ago

Expand username to cover whole line in mobile menu (#22074).

Patch by Gregor Schmidt.

History

#1 Updated by Go MAEDA almost 3 years ago

  • Target version set to 3.2.1

The fix works fine for me. Setting target version to 3.2.1.

#2 Updated by Gregor Schmidt almost 3 years ago

Sorry for hijacking this issue, but my problem is related.

If the user name is really short, e.g. a single letter, the menu entry does not cover the whole width, in contrast to the other menu entries. This makes touching the link needlessly complicated.

The second attached patch expands the user name link to cover the whole line.

#3 Updated by Jean-Philippe Lang almost 3 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Both patches are merged in 3.2, thanks.

Also available in: Atom PDF